You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem of constructor and destructor calls when reading std::vector of non-trivial types has come up in #8770. This fixes#9133.
To me it looks like we would benefit from storing information about trivially constructable/destructable types in the RField class. @jalopezg-r00t @eguiraud@pcanal Let me know what you think.
Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14 How to customize builds
@jblomer In TTree, it was found useful to let the user decide in the end whether to run the destructor or not. If the trivially does not indicate it is not necessary/needed, having a non-trivial destructor does not always (albeit often) indicates that it needs to be run (only the user/actual-code can tell us). So we would probably need to flag to default to 'run-the-destructor-only-if-not-trivial" but let the user over-ride it.
Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build See console output.
Errors:
[2021-10-20T22:53:22.906Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1045 (message):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem of constructor and destructor calls when reading std::vector of non-trivial types has come up in #8770. This fixes #9133.
To me it looks like we would benefit from storing information about trivially constructable/destructable types in the
RFieldclass. @jalopezg-r00t @eguiraud @pcanal Let me know what you think.