[RDFD][Fix #7205] Print() now indicates non-fitting columns#9124
[RDFD][Fix #7205] Print() now indicates non-fitting columns#9124eguiraud merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on mac11.0/cxx17. Failing tests: |
|
Great, I'll take a look as soon as possible! |
eguiraud
left a comment
eguiraud
left a comment
There was a problem hiding this comment.
Changes look good and the extra test coverage is great, thank you very much!
Just some minor comments inline, and the commit message has a typo, [RDFD] should be [DF].
|
Starting build on |
1 similar comment
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on ROOT-ubuntu2004/soversion. Failing tests: |
|
Starting build on |
|
Build failed on mac11.0/cxx17. Failing tests: |
In case of tables of many columns, Print() now have a right-most column of dots (...). Moreover, the user will be notified with an info message as well. Print() guarantees that at least 1 column of the table is displayed (regardless the width of the first column). The default maximum allowed width of the table is increased to 100 (from 80). New tests written to check the behaviour of wide tables.
ikabadzhov
force-pushed
the
RDF_Display_Columns
branch
from
6ffb013 to
87cba11
Compare
|
Starting build on |
|
@eguiraud done |
|
Build failed on mac11.0/cxx17. Failing tests: |
3 participants
This Pull request: [RDFD][Fix #7205] Print() now indicates non-fitting columns
Changes or fixes:
In case of tables of many columns, Print() now have a right-most
column of dots (...). Moreover, the user will be notified with an
info message as well.
Print() guarantees that at least 1 column of the table is displayed
(regardless the width of the first column).
The default maximum allowed width of the table is increased to 100
(from 80).
New tests written to check the behaviour of wide tables.
Checklist:
This PR fixes #7205