[ntuple,daos] RNTupleWriter::Recreate() now overwrites old ntuple#9033
Merged
jalopezg-git merged 1 commit intoroot-project:masterfrom Sep 28, 2021
Merged
Conversation
`DAOS_COND_DKEY_INSERT` was inappropriately used in `daos_obj_update()` calls,
which causes `RNTupleWriter::Recreate()` to not overwrite old data. This has
been fixed.
Additionally, `DAOS_COND_{D,A}KEY_FETCH` has been added to flags in
`daos_obj_fetch()` call (fail if dkey/akey does not exist).
Closes issue root-project#9032.
|
Starting build on |
|
Build failed on mac11.0/cxx17. Failing tests: |
pcanal
approved these changes
Sep 27, 2021
Contributor
Author
|
These failures are totally unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request fixes
RNTupleWriter::Recreate()in DAOS 1.2, where the old ntuple was not overwritten (see issue #9032).Changes or fixes:
DAOS_COND_DKEY_INSERTwas inappropriately used indaos_obj_update()calls, which causesRNTupleWriter::Recreate()to not overwrite old data. This has been fixed.Additionally,
DAOS_COND_{D,A}KEY_FETCHhas been added to flags indaos_obj_fetch()call (fail if dkey/akey does not exist).Checklist:
This PR fixes #9032.