MakeProject: generate operator= by pcanal · Pull Request #8995 · root-project/root

pcanal · 2021-09-14T20:02:53Z

This fixes #8987 (case where the base class deletes operator=).

In case where the class generated by MakeProject derived from a class that deletes the operator= then in some compiler we get the error below (which is expected since the class generated by MakeProject has a copy constructor which is needed by stl collection).

SRChh_ROOT6_mcgenProjectSource.cxx: In copy constructor ‘KKceex::KKceex(const KKceex&)’:
SRChh_ROOT6_mcgenProjectSource.cxx:922:54: error: use of deleted function ‘KKpart& KKpart::operator=(const KKpart&)’
  922 |    for (Int_t i=0;i<101;i++) m_Phot[i] = rhs.m_Phot[i];
      |                                                      ^
In file included from KKceex.h:21,
                 from KKhh2f.h:22,
                 from SRChh_ROOT6_mcgenProjectHeaders.h:1,
                 from SRChh_ROOT6_mcgenProjectSource.cxx:3:
KKpart.h:15:7: note: ‘KKpart& KKpart::operator=(const KKpart&)’ is implicitly declared as deleted because ‘KKpart’ declares a move constructor or move assignment operator
   15 | class KKpart : public TObject {
      |       ^~~~~~
c++: error: SRChh_ROOT6_mcgenProjectSource.o: No such file or directory

This fixes root-project#8987 (case where the base class deletes operator=). In case where the class generated by MakeProject derived from a class that deletes the operator= then in some compiler we get the error below (which is expected since the class generated by MakeProject has a copy constructor which is needed by stl collection). ``` SRChh_ROOT6_mcgenProjectSource.cxx: In copy constructor ‘KKceex::KKceex(const KKceex&)’: SRChh_ROOT6_mcgenProjectSource.cxx:922:54: error: use of deleted function ‘KKpart& KKpart::operator=(const KKpart&)’ 922 | for (Int_t i=0;i<101;i++) m_Phot[i] = rhs.m_Phot[i]; | ^ In file included from KKceex.h:21, from KKhh2f.h:22, from SRChh_ROOT6_mcgenProjectHeaders.h:1, from SRChh_ROOT6_mcgenProjectSource.cxx:3: KKpart.h:15:7: note: ‘KKpart& KKpart::operator=(const KKpart&)’ is implicitly declared as deleted because ‘KKpart’ declares a move constructor or move assignment operator 15 | class KKpart : public TObject { | ^~~~~~ c++: error: SRChh_ROOT6_mcgenProjectSource.o: No such file or directory ```

phsft-bot · 2021-09-14T20:03:00Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-09-14T20:37:02Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-09-14T21:27:01Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-09-15T00:07:08Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-09-14T21:53:05.042Z] ghprbPullLongDescription=This fixes Missing operator= in code generated by MakeProject #8987 (case where the base class deletes operator=).\r\n\r\nIn case where the class generated by MakeProject derived from a class that deletes the operator= then in some compiler we get the error below (which is expected since the class generated by MakeProject has a copy constructor which is needed by stl collection).\r\n\r\n\r\nSRChh_ROOT6_mcgenProjectSource.cxx: In copy constructor 'KKceex::KKceex(const KKceex&)':\r\nSRChh_ROOT6_mcgenProjectSource.cxx:922:54: error: use of deleted function 'KKpart& KKpart::operator=(const KKpart&)'\r\n 922 | for (Int_t i=0;i<101;i++) m_Phot[i] = rhs.m_Phot[i];\r\n | ^\r\nIn file included from KKceex.h:21,\r\n from KKhh2f.h:22,\r\n from SRChh_ROOT6_mcgenProjectHeaders.h:1,\r\n from SRChh_ROOT6_mcgenProjectSource.cxx:3:\r\nKKpart.h:15:7: note: 'KKpart& KKpart::operator=(const KKpart&)' is implicitly declared as deleted because 'KKpart' declares a move constructor or move assignment operator\r\n 15 | class KKpart : public TObject {\r\n | ^~~~~~\r\nc++: error: SRChh_ROOT6_mcgenProjectSource.o: No such file or directory\r\n\r\n\r\n

Failing tests:

pcanal · 2021-10-18T19:14:40Z

@phsft-bot build

phsft-bot · 2021-10-18T19:14:46Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-10-18T21:20:39Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-10-18T20:08:56.085Z] ghprbPullLongDescription=This fixes Missing operator= in code generated by MakeProject #8987 (case where the base class deletes operator=).\r\n\r\nIn case where the class generated by MakeProject derived from a class that deletes the operator= then in some compiler we get the error below (which is expected since the class generated by MakeProject has a copy constructor which is needed by stl collection).\r\n\r\n\r\nSRChh_ROOT6_mcgenProjectSource.cxx: In copy constructor 'KKceex::KKceex(const KKceex&)':\r\nSRChh_ROOT6_mcgenProjectSource.cxx:922:54: error: use of deleted function 'KKpart& KKpart::operator=(const KKpart&)'\r\n 922 | for (Int_t i=0;i<101;i++) m_Phot[i] = rhs.m_Phot[i];\r\n | ^\r\nIn file included from KKceex.h:21,\r\n from KKhh2f.h:22,\r\n from SRChh_ROOT6_mcgenProjectHeaders.h:1,\r\n from SRChh_ROOT6_mcgenProjectSource.cxx:3:\r\nKKpart.h:15:7: note: 'KKpart& KKpart::operator=(const KKpart&)' is implicitly declared as deleted because 'KKpart' declares a move constructor or move assignment operator\r\n 15 | class KKpart : public TObject {\r\n | ^~~~~~\r\nc++: error: SRChh_ROOT6_mcgenProjectSource.o: No such file or directory\r\n\r\n\r\n

phsft-bot · 2021-10-18T23:01:48Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal · 2022-01-19T16:13:05Z

@phsft-bot build

phsft-bot · 2022-01-19T16:13:11Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-19T20:33:26Z

Build failed on mac1015/python3.
Running on macitois22.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_snapshot

phsft-bot · 2022-01-19T21:37:06Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 4 more

phsft-bot · 2022-01-20T00:49:27Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2022-01-19T22:58:41.859Z] ghprbPullLongDescription=This fixes Missing operator= in code generated by MakeProject #8987 (case where the base class deletes operator=).\r\n\r\nIn case where the class generated by MakeProject derived from a class that deletes the operator= then in some compiler we get the error below (which is expected since the class generated by MakeProject has a copy constructor which is needed by stl collection).\r\n\r\n\r\nSRChh_ROOT6_mcgenProjectSource.cxx: In copy constructor 'KKceex::KKceex(const KKceex&)':\r\nSRChh_ROOT6_mcgenProjectSource.cxx:922:54: error: use of deleted function 'KKpart& KKpart::operator=(const KKpart&)'\r\n 922 | for (Int_t i=0;i<101;i++) m_Phot[i] = rhs.m_Phot[i];\r\n | ^\r\nIn file included from KKceex.h:21,\r\n from KKhh2f.h:22,\r\n from SRChh_ROOT6_mcgenProjectHeaders.h:1,\r\n from SRChh_ROOT6_mcgenProjectSource.cxx:3:\r\nKKpart.h:15:7: note: 'KKpart& KKpart::operator=(const KKpart&)' is implicitly declared as deleted because 'KKpart' declares a move constructor or move assignment operator\r\n 15 | class KKpart : public TObject {\r\n | ^~~~~~\r\nc++: error: SRChh_ROOT6_mcgenProjectSource.o: No such file or directory\r\n\r\n\r\n

pcanal · 2022-01-20T02:54:12Z

The failures are unrelated

pcanal added the in:I/O label Sep 14, 2021

pcanal self-assigned this Sep 14, 2021

pcanal requested a review from Axel-Naumann September 14, 2021 20:03

Axel-Naumann approved these changes Dec 12, 2021

View reviewed changes

pcanal merged commit f705d41 into root-project:master Jan 20, 2022

pcanal deleted the master-issue-8987 branch January 20, 2022 12:49

Conversation

pcanal commented Sep 14, 2021

Uh oh!

phsft-bot commented Sep 14, 2021

Uh oh!

phsft-bot commented Sep 14, 2021

Failing tests:

Uh oh!

phsft-bot commented Sep 14, 2021

Failing tests:

Uh oh!

phsft-bot commented Sep 15, 2021

Errors:

Failing tests:

Uh oh!

pcanal commented Oct 18, 2021

Uh oh!

phsft-bot commented Oct 18, 2021

Uh oh!

phsft-bot commented Oct 18, 2021

Errors:

Uh oh!

phsft-bot commented Oct 18, 2021

Failing tests:

Uh oh!

pcanal commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 19, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 20, 2022

Errors:

Uh oh!

pcanal commented Jan 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants