6-24: [core] TDirectory::RegisterGDirectory must not update other TDirectory without lock:#8929
Merged
Axel-Naumann merged 1 commit intoroot-project:v6-24-00-patchesfrom Aug 30, 2021
Conversation
…y without lock: As we cannot even know whether the other TDirectory has been deleted in the meantime, we have to skip the optimization of erasing globalptr from the list of the oldvalue. This is expected to fix MT crashes observed by Alice. (cherry picked from commit 79a669b)
|
Starting build on |
|
Build failed on mac11.0/cxx17. Errors:
|
|
Build failed on windows10/cxx14. Failing tests: |
Member
Author
|
@phsft-bot build just on mac11.0/cxx17 |
|
Starting build on |
pcanal
approved these changes
Aug 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we cannot even know whether the other TDirectory has been deleted in the meantime, we have to
skip the optimization of erasing globalptr from the list of the oldvalue.
This is expected to fix MT crashes observed by Alice.
(cherry picked from commit 79a669b)
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #