Skip to content

[netxng] Delete XrdFile already at Close():#8802

Merged
Axel-Naumann merged 1 commit intoroot-project:v6-24-00-patchesfrom
Axel-Naumann:issue8767-netxng-xrdfile-delete-624
Aug 5, 2021
Merged

[netxng] Delete XrdFile already at Close():#8802
Axel-Naumann merged 1 commit intoroot-project:v6-24-00-patchesfrom
Axel-Naumann:issue8767-netxng-xrdfile-delete-624

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

This prevents the deletion of the TNetXNGFile triggered by static
destruction (TROOT::~TROOT() deleting open files) at a point where
the Xrootd client library had its static destruction already run,
and thus the call to XrdCl::File::~File() fails.

Fixes #8767.

(cherry picked from commit 3845be7)

This prevents the deletion of the TNetXNGFile triggered by static
destruction (TROOT::~TROOT() deleting open files) at a point where
the Xrootd client library had its static destruction already run,
and thus the call to XrdCl::File::~File() fails.

Fixes root-project#8767.

(cherry picked from commit 3845be7)
@Axel-Naumann Axel-Naumann added this to the 6.24/04 milestone Aug 5, 2021
@Axel-Naumann Axel-Naumann self-assigned this Aug 5, 2021
@Axel-Naumann Axel-Naumann requested a review from gganis as a code owner August 5, 2021 08:02
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann removed the request for review from gganis August 5, 2021 08:02
@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@Axel-Naumann Axel-Naumann merged commit 167fa9c into root-project:v6-24-00-patches Aug 5, 2021
@Axel-Naumann Axel-Naumann deleted the issue8767-netxng-xrdfile-delete-624 branch August 5, 2021 12:13
@Axel-Naumann Axel-Naumann linked an issue Aug 6, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[netxng] Crash in on-exit destruction of an TNetXNGFile object

2 participants