Skip to content

[treeplayer] Fix TSimpleAnalysis / rootdrawtree with no args.#8786

Merged
Axel-Naumann merged 3 commits intoroot-project:masterfrom
Axel-Naumann:fix-drawtree-no-files
Oct 28, 2021
Merged

[treeplayer] Fix TSimpleAnalysis / rootdrawtree with no args.#8786
Axel-Naumann merged 3 commits intoroot-project:masterfrom
Axel-Naumann:fix-drawtree-no-files

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

Fixes #8778.

@Axel-Naumann Axel-Naumann requested a review from pcanal as a code owner July 31, 2021 10:43
@Axel-Naumann Axel-Naumann self-assigned this Jul 31, 2021
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

1 similar comment
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@ghost
Copy link
Copy Markdown

ghost commented Jul 31, 2021

DeepCode's analysis on #101601 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Replace exit with sys.exit. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-31T11:02:35.937Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

@Axel-Naumann Axel-Naumann force-pushed the fix-drawtree-no-files branch from 1016017 to 5261ee8 Compare October 25, 2021 13:02
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@Axel-Naumann
Copy link
Copy Markdown
Member Author

Failures are pre-existing

@Axel-Naumann Axel-Naumann merged commit 2987bbe into root-project:master Oct 28, 2021
@Axel-Naumann Axel-Naumann deleted the fix-drawtree-no-files branch October 28, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rootdrawtree crash

3 participants