Skip to content

[cmake] Fix building ROOT with external llvm.#8766

Merged
vgvassilev merged 1 commit intoroot-project:masterfrom
vgvassilev:fix-gh-8141
Aug 17, 2021
Merged

[cmake] Fix building ROOT with external llvm.#8766
vgvassilev merged 1 commit intoroot-project:masterfrom
vgvassilev:fix-gh-8141

Conversation

@vgvassilev
Copy link
Copy Markdown
Member

@vgvassilev vgvassilev commented Jul 28, 2021

Fixes #8141.

This PR requires a new clad release v0.9. The clad master is incompatible with ROOT atm and the release of 0.9 depends on #8371

@vgvassilev vgvassilev requested a review from bellenot as a code owner July 28, 2021 19:23
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@vgvassilev vgvassilev mentioned this pull request Jul 28, 2021
Closed
1 task
@vgvassilev vgvassilev marked this pull request as draft July 28, 2021 19:24
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-28T19:24:29.660Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jul 28, 2021

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@vgvassilev vgvassilev marked this pull request as ready for review August 16, 2021 20:41
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Aug 16, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Aug 16, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Aug 16, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-08-16T20:43:58.247Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

veprbl
veprbl approved these changes Aug 17, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with vanilla LLVM on x86_64-darwin. Thanks!

bellenot
bellenot approved these changes Aug 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seems to work...

@vgvassilev vgvassilev merged commit 0cddef5 into root-project:master Aug 17, 2021
@vgvassilev vgvassilev deleted the fix-gh-8141 branch August 17, 2021 08:25
@vgvassilev
Copy link
Copy Markdown
Member Author

vgvassilev commented Aug 17, 2021

Thanks!

@vgvassilev vgvassilev mentioned this pull request Sep 14, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot bellenot approved these changes

+1 more reviewer

@veprbl veprbl veprbl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vgvassilev vgvassilev

Labels

in:Cling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cmake get_directory_property fails on external LLVM

5 participants

@vgvassilev @phsft-bot @veprbl @bellenot @guitargeek