[cling,tcling] Allow reporting cling diagnostics via the ROOT error handler by jalopezg-git · Pull Request #8737 · root-project/root

jalopezg-git · 2021-07-26T21:02:15Z

This PR enables cling diagnostics to be reported via the ROOT error handler, as required by the experiments. Independently, this error handler may be changed by the user (see TError.h), e.g.

root [0] int f() { return; }
ROOT_prompt_0:1:11: non-void function 'f' should return a value [-Wreturn-type]
int f() { return; }
          ^

root [1] gInterpreter->ReportDiagnosticsToErrorHandler();
root [2] int f() { return; }
Error in <cling>: ROOT_prompt_2:1:11: non-void function 'f' should return a value [-Wreturn-type]
int f() { return; }
          ^
root [3] // Note the previous error is reported through the default ROOT error handler.

Changes in this PR

Required changes to FilteringDiagConsumer (in IncrementalParser.cpp).
Two member functions have been added to the Interpreter class:
- void replaceDiagnosticConsumer(clang::DiagnosticConsumer* Consumer, bool Own): replaces the default CIFactory-provided diagnostic consumer.
- bool hasReplacedDiagnosticConsumer(): returns whether the default diagnostic consumer has been replaced.
Added void TCling::ReportDiagnosticsToErrorHandler(bool enable) member function.

This PR closes JIRA issue ROOT-7587.

Link to sibling PR in roottest repository: root-project/roottest#761.

phsft-bot · 2021-07-26T21:02:23Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-26T22:01:22Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-26T21:03:31.578Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

phsft-bot · 2021-07-26T22:19:06Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

core/metacling/src/TClingDiagnostics.cxx

interpreter/cling/lib/Interpreter/IncrementalParser.cpp

phsft-bot · 2021-07-28T13:28:33Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

jalopezg-git · 2021-07-28T14:50:38Z

@Axel-Naumann, @vgvassilev, given that I will be off in August, feel free to merge this PR and the sibling PR in roottest if the code doesn't need changes after the review.

phsft-bot · 2021-07-28T15:26:03Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cpp.roottest_python_cpp_cpp

phsft-bot · 2021-07-29T09:54:42Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-29T09:56:40Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-29T09:56:35.012Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-29T09:56:37.910Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-29T09:56:38.489Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

jalopezg-git · 2021-07-29T14:42:23Z

@phsft-bot build just on ROOT-debian10-i386/cxx14

phsft-bot · 2021-07-29T14:42:28Z

Starting build on ROOT-debian10-i386/cxx14
How to customize builds

phsft-bot · 2021-07-29T15:17:19Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-29T15:17:14.616Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-29T15:17:18.426Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-29T15:17:18.684Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

hahnjo

Very cool that you made the restoring work naturally, good job 👍

interpreter/cling/lib/Interpreter/IncrementalParser.cpp

phsft-bot · 2021-07-30T09:38:10Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-30T09:40:28Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-30T09:40:23.739Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-30T09:40:26.554Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory
[2021-07-30T09:40:27.076Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

Axel-Naumann

Looks great! But I have a question! :-)

interpreter/cling/lib/Interpreter/IncrementalParser.cpp

jalopezg-git · 2021-09-08T10:53:56Z

@phsft-bot build

phsft-bot · 2021-09-08T10:54:01Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-09-08T11:01:58Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-09-08T11:01:57.698Z] CMake Error at cmake/modules/RootBuildOptions.cmake:407 (message):
[2021-09-08T11:01:57.698Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1117 (message):

phsft-bot · 2021-09-08T11:08:26Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-09-08T11:08:25.953Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

phsft-bot · 2021-09-08T12:11:51Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 4 more

phsft-bot · 2021-09-08T13:19:18Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

These changes enable the replacement of the default DiagnosticConsumer provided by CIFactory. Concretely, two member functions have been added to the Interpreter class: - replaceDiagnosticConsumer(): replaces the default CIFactory-provided DiagnosticConsumer. - hasReplacedDiagnosticConsumer(): returns whether the default diagnostic consumer has been replaced.

This function allows users to route clang diagnostics to the ROOT error handler. Closes issue ROOT-7587.

phsft-bot · 2021-09-08T13:22:10Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-09-08T13:33:22Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-09-08T13:33:21.526Z] CMake Error at cmake/modules/RootBuildOptions.cmake:407 (message):
[2021-09-08T13:33:21.526Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1117 (message):

phsft-bot · 2021-09-08T15:54:28Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-09-08T15:54:27.775Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

phsft-bot · 2021-09-08T15:55:05Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

jalopezg-git · 2021-09-08T17:14:07Z

@phsft-bot build just on ROOT-debian10-i386/cxx14

phsft-bot · 2021-09-08T17:14:12Z

Starting build on ROOT-debian10-i386/cxx14
How to customize builds

phsft-bot · 2021-09-08T22:00:21Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-09-08T22:00:20.178Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1084 (message):

jalopezg-git added improvement in:Cling labels Jul 26, 2021

jalopezg-git requested review from Axel-Naumann, hahnjo and vgvassilev July 26, 2021 21:02

jalopezg-git self-assigned this Jul 26, 2021

jalopezg-git requested review from bellenot and pcanal as code owners July 26, 2021 21:02

vgvassilev reviewed Jul 27, 2021

View reviewed changes

core/metacling/src/TClingDiagnostics.cxx Show resolved Hide resolved

interpreter/cling/lib/Interpreter/IncrementalParser.cpp Outdated Show resolved Hide resolved

jalopezg-git force-pushed the cling-custom-diagnosticconsumer branch from 4739633 to 492d42e Compare July 28, 2021 13:28

jalopezg-git mentioned this pull request Jul 28, 2021

[tcling] Added test for TCling::ReportDiagnosticsToErrorHandler() root-project/roottest#761

Merged

jalopezg-git force-pushed the cling-custom-diagnosticconsumer branch from 492d42e to faf1ace Compare July 29, 2021 09:54

hahnjo approved these changes Jul 30, 2021

View reviewed changes

interpreter/cling/lib/Interpreter/IncrementalParser.cpp Show resolved Hide resolved

interpreter/cling/lib/Interpreter/IncrementalParser.cpp Show resolved Hide resolved

jalopezg-git force-pushed the cling-custom-diagnosticconsumer branch from faf1ace to 13e08bc Compare July 30, 2021 09:37

Axel-Naumann approved these changes Sep 6, 2021

View reviewed changes

interpreter/cling/lib/Interpreter/IncrementalParser.cpp Show resolved Hide resolved

jalopezg-git force-pushed the cling-custom-diagnosticconsumer branch from 13e08bc to 3fa0d5b Compare September 8, 2021 13:19

jalopezg-git added 2 commits September 8, 2021 15:21

[tcling] Implement TCling::ReportDiagnosticsToErrorHandler()

63caf67

This function allows users to route clang diagnostics to the ROOT error handler. Closes issue ROOT-7587.

jalopezg-git force-pushed the cling-custom-diagnosticconsumer branch from 3fa0d5b to 63caf67 Compare September 8, 2021 13:22

jalopezg-git merged commit c0cbfe1 into root-project:master Sep 9, 2021

jalopezg-git deleted the cling-custom-diagnosticconsumer branch September 9, 2021 12:44

jalopezg-git mentioned this pull request Mar 15, 2022

[cling,tcling,v6-24] Allow reporting cling diagnostics via the ROOT error handler #10123

Merged

Conversation

jalopezg-git commented Jul 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in this PR

Uh oh!

phsft-bot commented Jul 26, 2021

Uh oh!

phsft-bot commented Jul 26, 2021

Errors:

Failing tests:

Uh oh!

phsft-bot commented Jul 26, 2021

Failing tests:

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Jul 28, 2021

Uh oh!

jalopezg-git commented Jul 28, 2021

Uh oh!

phsft-bot commented Jul 28, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 29, 2021

Uh oh!

phsft-bot commented Jul 29, 2021

Errors:

Uh oh!

jalopezg-git commented Jul 29, 2021

Uh oh!

phsft-bot commented Jul 29, 2021

Uh oh!

phsft-bot commented Jul 29, 2021

Errors:

Uh oh!

hahnjo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

phsft-bot commented Jul 30, 2021

Uh oh!

phsft-bot commented Jul 30, 2021

Errors:

Uh oh!

Axel-Naumann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jalopezg-git commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

Errors:

Uh oh!

phsft-bot commented Sep 8, 2021

Errors:

Uh oh!

phsft-bot commented Sep 8, 2021

Failing tests:

Uh oh!

phsft-bot commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

Errors:

Uh oh!

phsft-bot commented Sep 8, 2021

Errors:

Uh oh!

phsft-bot commented Sep 8, 2021

Failing tests:

Uh oh!

jalopezg-git commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

Uh oh!

phsft-bot commented Sep 8, 2021

jalopezg-git commented Jul 26, 2021 •

edited

Loading