grab CTRL+s in TGMainFrame also if NumLock active#8677
Merged
bellenot merged 3 commits intoroot-project:masterfrom Aug 4, 2021
Merged
grab CTRL+s in TGMainFrame also if NumLock active#8677bellenot merged 3 commits intoroot-project:masterfrom
bellenot merged 3 commits intoroot-project:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Collaborator
Author
|
This change mimicks what's already being done in: |
bellenot
approved these changes
Jul 15, 2021
Member
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
Collaborator
Author
|
Note: failing test is unrelated. |
pzhristov
pushed a commit
to alisw/root
that referenced
this pull request
Aug 27, 2021
* grab CTRL+s in TGMainFrame also if NumLock active Fixes root-project#8665 * NumLock incompatibility in TRootGuiBuilder * both variants are needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
CTRL shortcuts X11Grab were not working if NumLock was enabled.
Checklist:
This PR fixes #8665