Remove accidentally introduced I/O capabilities of RooMinimizer#8653
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Jul 13, 2021
Merged
Remove accidentally introduced I/O capabilities of RooMinimizer#8653guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
root-project#8569 set the ClassDef version to 1, while it was zero before. Zero was a special value meaning "no I/O needed" (see https://root.cern.ch/root/html534/guides/users-guide/AddingaClass.html#motivation). This commit resets it to zero. Fixes root-project#8652.
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
Failing tests: |
guitargeek
approved these changes
Jul 13, 2021
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thank you very much for the quick fix! And sorry again for recommending to increase the class version to begin with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8569 set the ClassDef version to 1, while it was zero before. Zero was a special value meaning "no I/O needed" (see https://root.cern.ch/root/html534/guides/users-guide/AddingaClass.html#motivation). This PR/commit resets it to zero.
Fixes #8652.