Require C++14 for ROOT, C++17 for ROOT7 by Axel-Naumann · Pull Request #8583 · root-project/root

Axel-Naumann · 2021-07-01T07:18:28Z

No description provided.

Given the ubiquitous access and existing use of C++ standards > 2011 ROOT will start having C++ constructs only available in C++14, i.e. requiring a C++14-capable compiler.

As these are still experimental, and expected to go into production only in a few years, and as this code is meant to survive for many years to come, require the much more expressive, compact, and simpler to maintain C++17 standard.

phsft-bot · 2021-07-01T07:18:35Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-01T07:21:45Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-01T07:21:43.824Z] CMake Error at cmake/modules/CheckCompiler.cmake:168 (message):
[2021-07-01T07:21:43.824Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1112 (message):

phsft-bot · 2021-07-01T07:24:35Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-01T07:24:34.321Z] CMake Error at cmake/modules/CheckCompiler.cmake:168 (message):
[2021-07-01T07:24:34.321Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1112 (message):

phsft-bot · 2021-07-01T07:27:04Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-01T07:27:03.344Z] CMake Error at cmake/modules/CheckCompiler.cmake:168 (message):
[2021-07-01T07:27:03.344Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1112 (message):

phsft-bot · 2021-07-01T08:53:18Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-07-01T09:37:54Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

Axel-Naumann · 2021-07-05T07:18:47Z

@phsft-bot build

phsft-bot · 2021-07-05T07:18:53Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-05T07:43:04Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-05T08:16:34Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-07-05T08:40:59Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-05T08:47:55Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-05T09:26:47Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-06T08:49:48Z

Starting build on mac11.0/cxx17
How to customize builds

Axel-Naumann · 2021-07-06T08:51:43Z

@phsft-bot build just on mac11.0/cxx17

phsft-bot · 2021-07-06T08:51:49Z

Starting build on mac11.0/cxx17
How to customize builds

phsft-bot · 2021-07-06T08:52:17Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-06T08:52:16.043Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1045 (message):

Axel-Naumann · 2021-07-06T08:53:08Z

@phsft-bot build just on mac11.0/cxx17

phsft-bot · 2021-07-06T08:53:13Z

Starting build on mac11.0/cxx17
How to customize builds

Axel-Naumann · 2021-07-06T10:13:16Z

@phsft-bot build just on mac11.0/cxx17

phsft-bot · 2021-07-06T10:13:22Z

Starting build on mac11.0/cxx17
How to customize builds

Axel-Naumann · 2021-07-06T12:43:18Z

@phsft-bot build

phsft-bot · 2021-07-06T12:43:24Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-06T13:16:52Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-06T14:14:39Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-06T14:14:27.650Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/build/TBB-prefix/src/TBB-stamp/TBB-build-Release.cmake:49 (message):

phsft-bot · 2021-07-06T14:55:51Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-06T16:18:15Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-07-06T16:18:01.055Z] FAILED: interpreter/llvm/src/tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTReaderStmt.cpp.o
[2021-07-06T16:18:01.314Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/lib/Serialization/ASTReaderStmt.cpp:34:10: fatal error: 'clang/AST/StmtOpenMP.h' file not found
[2021-07-06T16:18:01.314Z] FAILED: interpreter/llvm/src/tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTWriterStmt.cpp.o
[2021-07-06T16:18:01.572Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/lib/Serialization/ASTWriterStmt.cpp:19:10: fatal error: 'clang/AST/StmtVisitor.h' file not found
[2021-07-06T16:18:01.572Z] FAILED: interpreter/llvm/src/tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTWriter.cpp.o
[2021-07-06T16:18:01.572Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include/clang/Lex/Preprocessor.h:26:10: fatal error: 'clang/Lex/Lexer.h' file not found
[2021-07-06T16:18:01.572Z] FAILED: interpreter/llvm/src/tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/ASTWriterDecl.cpp.o
[2021-07-06T16:18:01.830Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/lib/Serialization/ASTWriterDecl.cpp:23:10: fatal error: 'clang/Serialization/ASTWriter.h' file not found
[2021-07-06T16:18:01.831Z] FAILED: interpreter/llvm/src/tools/clang/lib/Serialization/CMakeFiles/obj.clangSerialization.dir/GeneratePCH.cpp.o
[2021-07-06T16:18:02.088Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/interpreter/llvm/src/tools/clang/include/clang/AST/TypeLoc.h:50:10: fatal error: 'clang/AST/TypeLocNodes.def' file not found

And 4 more

phsft-bot · 2021-07-06T18:43:29Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

Axel-Naumann · 2021-07-07T09:03:17Z

@phsft-bot build

phsft-bot · 2021-07-07T09:03:23Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-07-07T09:33:13Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-07T10:11:25Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-07-07T10:15:42Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-07T11:43:44Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

phsft-bot · 2021-07-07T11:46:57Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.core.metacling.test.gtest_core_metacling_test_TClingTest

Axel-Naumann added 2 commits July 1, 2021 09:13

[cmake] Require C++14 or later:

60947d4

Given the ubiquitous access and existing use of C++ standards > 2011 ROOT will start having C++ constructs only available in C++14, i.e. requiring a C++14-capable compiler.

[cmake] Require C++17 for ROOT7 features:

a626b72

As these are still experimental, and expected to go into production only in a few years, and as this code is meant to survive for many years to come, require the much more expressive, compact, and simpler to maintain C++17 standard.

Axel-Naumann added this to the 6.26/00 milestone Jul 1, 2021

Axel-Naumann requested a review from bellenot July 1, 2021 07:18

Axel-Naumann self-assigned this Jul 1, 2021

bellenot approved these changes Jul 1, 2021

View reviewed changes

root-project deleted a comment from phsft-bot Jul 6, 2021

Axel-Naumann merged commit de5e78c into root-project:master Jul 7, 2021

Axel-Naumann deleted the require-cxx14 branch July 7, 2021 12:50

hahnjo mentioned this pull request Jul 12, 2021

Some parts of ROOT still mention C++11 #8643

Closed

guitargeek mentioned this pull request Dec 28, 2022

[RF] Remove RooFormula code for gcc <= 4.8 when minimum standard is raised to C++17 #11964

Closed

Conversation

Axel-Naumann commented Jul 1, 2021

Uh oh!

phsft-bot commented Jul 1, 2021

Uh oh!

phsft-bot commented Jul 1, 2021

Errors:

Uh oh!

phsft-bot commented Jul 1, 2021

Errors:

Uh oh!

phsft-bot commented Jul 1, 2021

Errors:

Uh oh!

phsft-bot commented Jul 1, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 1, 2021

Failing tests:

Uh oh!

Axel-Naumann commented Jul 5, 2021

Uh oh!

phsft-bot commented Jul 5, 2021

Uh oh!

phsft-bot commented Jul 5, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 5, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 5, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 5, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 5, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 6, 2021

Uh oh!

Axel-Naumann commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Errors:

Uh oh!

Axel-Naumann commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Uh oh!

Axel-Naumann commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Uh oh!

Axel-Naumann commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Uh oh!

phsft-bot commented Jul 6, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 6, 2021

Errors:

Uh oh!

phsft-bot commented Jul 6, 2021

Failing tests:

Uh oh!

phsft-bot commented Jul 6, 2021

Errors:

Uh oh!

phsft-bot commented Jul 6, 2021

Failing tests:

Uh oh!

Axel-Naumann commented Jul 7, 2021

Uh oh!

phsft-bot commented Jul 7, 2021

Uh oh!

phsft-bot commented Jul 7, 2021