Skip to content

stop tgcommandplugin timer when remote check not needed#8561

Merged
bellenot merged 4 commits intoroot-project:masterfrom
ferdymercury:patch-13
Jun 30, 2021
Merged

stop tgcommandplugin timer when remote check not needed#8561
bellenot merged 4 commits intoroot-project:masterfrom
ferdymercury:patch-13

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Jun 28, 2021

This Pull request:

Changes or fixes:

Let user stop internal timer, for performance reasons, when there is a priori knowledge that there is no remote check needed.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #8269

@ferdymercury ferdymercury requested a review from bellenot as a code owner June 28, 2021 22:27
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 28, 2021

Can one of the admins verify this patch?

@bellenot bellenot self-assigned this Jun 29, 2021
@bellenot
Copy link
Copy Markdown
Member

bellenot commented Jun 29, 2021

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 29, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 29, 2021

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-29T06:27:21.723Z] FAILED: core/thread/CMakeFiles/Thread.dir/src/TPosixThread.cxx.o
  • [2021-06-29T06:27:21.982Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:41:7: error: unknown type name 'cpu_set_t'
  • [2021-06-29T06:27:21.982Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:44:48: error: use of undeclared identifier 'cpu_set_t'; did you mean 'cpuset'?

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 29, 2021

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-29T06:45:06.876Z] FAILED: core/thread/CMakeFiles/Thread.dir/src/TPosixThread.cxx.o
  • [2021-06-29T06:45:07.134Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:41:7: error: unknown type name 'cpu_set_t'
  • [2021-06-29T06:45:07.134Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/core/thread/src/TPosixThread.cxx:44:48: error: use of undeclared identifier 'cpu_set_t'; did you mean 'cpuset'?

bellenot
bellenot reviewed Jun 30, 2021
View reviewed changes
@bellenot
Copy link
Copy Markdown
Member

bellenot commented Jun 30, 2021

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 30, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 30, 2021

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 30, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 30, 2021

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 37 more

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 30, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

bellenot
bellenot approved these changes Jun 30, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bellenot bellenot merged commit 4e568a9 into root-project:master Jun 30, 2021
@ferdymercury ferdymercury deleted the patch-13 branch June 30, 2021 13:33
AdvaitDhingra pushed a commit to AdvaitDhingra/root that referenced this pull request Jul 5, 2021
@ferdymercury @AdvaitDhingra
stop tgcommandplugin timer when remote check not needed (root-project…
e000160 
…#8561)

* add function to stop timer

Fixes root-project#8269

* add public function to stop timer

* let turn on or off

* let user start and stop at will
AdvaitDhingra pushed a commit to AdvaitDhingra/root that referenced this pull request Jul 5, 2021
@ferdymercury @AdvaitDhingra
stop tgcommandplugin timer when remote check not needed (root-project…
e2ec6be 
…#8561)

* add function to stop timer

Fixes root-project#8269

* add public function to stop timer

* let turn on or off

* let user start and stop at will
pzhristov pushed a commit to alisw/root that referenced this pull request Aug 27, 2021
@ferdymercury
stop tgcommandplugin timer when remote check not needed (root-project…
a6a6be2 
…#8561)

* add function to stop timer

Fixes root-project#8269

* add public function to stop timer

* let turn on or off

* let user start and stop at will
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot bellenot approved these changes

Assignees

@bellenot bellenot

Labels

in:GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TGCommandPlugin TTimer

3 participants

@ferdymercury @phsft-bot @bellenot