Fix for assembling mixtures made of isomere elements.#8556
Merged
agheata merged 1 commit intoroot-project:masterfrom Jun 29, 2021
agheata:fix_isomers
Merged
Fix for assembling mixtures made of isomere elements.#8556agheata merged 1 commit intoroot-project:masterfrom agheata:fix_isomers
agheata merged 1 commit intoroot-project:masterfrom
agheata:fix_isomers
Conversation
|
Starting build on |
couet
approved these changes
Jun 29, 2021
This was referenced Aug 24, 2021
pzhristov
pushed a commit
to alisw/root
that referenced
this pull request
Aug 27, 2021
sjgardiner
added a commit
to sjgardiner/Generator
that referenced
this pull request
Jun 19, 2023
PDG code. This is no longer necessarily an error condition due to changes in how ROOT v6.25.02 handles isomers. See root-project/root#8556 for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes creation of mixtures made of isomere elements having the same A and Z. The previous behavior was to compact such elements into a single one, which is wrong in the case of such mixtures. Printing mixture defined by elements calls now the Print method of the elements.
Changes or fixes:
Fixes issue reported in the forum: https://root-forum.cern.ch/t/tgeomixture-cannot-distinguish-isomers/45451
Checklist:
This PR fixes #