Skip to content

parse correctly the compiler version#8553

Merged
Axel-Naumann merged 2 commits intoroot-project:masterfrom
ferdymercury:patch-11
Jul 7, 2021
Merged

parse correctly the compiler version#8553
Axel-Naumann merged 2 commits intoroot-project:masterfrom
ferdymercury:patch-11

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Jun 28, 2021

This Pull request:

Changes or fixes:

Fixes the incorrect parsing of the gcc version on Ubuntu 18 or 20.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #8551

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 28, 2021

Can one of the admins verify this patch?

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jun 28, 2021

Thanks, @ferdymercury ! (Note so self: we should really ask CMake to generate that header for us...)

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jun 28, 2021

@phsft-bot build

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 28, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jun 28, 2021 •
edited
Loading

GCC 4.8 doesn't like -dumpfullversion:

cc1plus: warning: unrecognized gcc debugging option: u [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: m [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: f [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: u [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: l [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: l [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: v [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: e [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: r [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: s [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: i [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: o [enabled by default]
cc1plus: warning: unrecognized gcc debugging option: n [enabled by default]
Compiler returned: 0

Let's wait for tonight, we might not care about GCC 4.8 after this afternoon's ROOT meeting.

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Jul 6, 2021

Or shall I maybe make an 'if gccversion < 5 then ... else ...' ?

@Axel-Naumann
Copy link
Copy Markdown
Member

Axel-Naumann commented Jul 7, 2021

Turns out we now require C++14 in master which excludes GCC 4.8 :-P ;-) So this PR is good to go, thanks, @ferdymercury !

@Axel-Naumann Axel-Naumann merged commit 6e85bbe into root-project:master Jul 7, 2021
@ferdymercury ferdymercury deleted the patch-11 branch July 7, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler Version not correctly parsed

3 participants

@ferdymercury @phsft-bot @Axel-Naumann