MathMore: Add Lambert W functions#8496
Conversation
|
Can one of the admins verify this patch? |
stephanlachnit
force-pushed
the
p/lambert-w
branch
from
7a19ec5 to
2a4c6ad
Compare
|
@phsft-bot build ! |
|
Starting build on |
|
@phsft-bot build |
|
Starting build on |
|
Thank you for the PR. @stephanlachnit Is it completed and ready to be reviewed ? The numbers in the doc, they are probably some and tags used in some past documentation of the Math libraries. I think they can be removed now since they are not used. |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
Ok thanks. I'll remove the numbers and rebase. Else the code is ready to be reviewed, I tested the changes locally and added unit tests. |
stephanlachnit
force-pushed
the
p/lambert-w
branch
from
2a4c6ad to
1906b06
Compare
stephanlachnit
changed the title
|
@lmoneta Rebased and updated docs, ready to review now. |
This add the Lambert W functions for branch 0 and branch -1 via GSL. Signed-off-by: Stephan Lachnit <[email protected]>
stephanlachnit
force-pushed
the
p/lambert-w
branch
from
1906b06 to
27a59b1
Compare
|
@phsft-bot build |
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
@lmoneta friendly ping :) I don't the think the failing test are connected to the PR, but I can't see the logs. |
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Looks good ! Thank you for the contribution. .
I think we can merge it in the ROOT master
4 participants
This Pull request:
Changes or fixes:
Adds the Lambert W function to MathMore using GSL.
One question: I'm not sure what some of the docstrings in the source file mean.
I copied these from other functions:
Does the first one specify the version the function is introduced? What does the second number specify?
I tested it and it works, the only thing missing are the docstrings.
Checklist:
This PR fixes #8471.
/cc @lmoneta