Extend io customization support: whole obj rule in split obj. by pcanal · Pull Request #8429 · root-project/root

pcanal · 2021-06-14T22:56:30Z

Extend the support for a rule that applies to several data members (and thus currently is applied as the 'object level') to
the case of a split object embedded within a split subobject of an object (previous it worked only for the collection case).

This fixes issue #8428 , see also https://cdcvs.fnal.gov/redmine/issues/25893.

This PR fixes #8428

phsft-bot · 2021-06-14T22:56:37Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

pcanal · 2021-06-14T22:57:15Z

test pending.

pcanal · 2021-06-14T22:59:37Z

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

phsft-bot · 2021-06-14T22:59:42Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

phsft-bot · 2021-06-14T23:58:30Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.runtutorials.tutorial_roofit_rf408_RDataFrameToRooFit

phsft-bot · 2021-06-14T23:59:46Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-06-14T23:57:42.987Z] C:\build\workspace\root-pullrequests-build\build\test\Release\stressRooFit.exe : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\test\stressRooFit.vcxproj]
[2021-06-14T23:57:46.492Z] C:\build\workspace\root-pullrequests-build\build\bin\libRooStats.dll : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\roofit\roostats\RooStats.vcxproj]
[2021-06-14T23:58:17.421Z] C:\build\workspace\root-pullrequests-build\build\roofit\roofitcore\test\Release\testRooAbsPdf.exe : fatal error LNK1120: 1 unresolved externals [C:\build\workspace\root-pullrequests-build\build\roofit\roofitcore\test\testRooAbsPdf.vcxproj]

greenc-FNAL · 2021-06-15T15:01:18Z

Back-ported to root-project:v6-22-00-patches at chissg:hotfix/v6-22-00-patches-8428. Local build successful on scisoftbuild01, fix validation in progress by Kyle.

jblomer

Looks fine to me although I don't understand all the implications. Perhaps a comment could be added on the meaning of fElemId != (UInt_t)-1.

phsft-bot · 2021-06-22T21:16:53Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-25T23:32:10Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

ghost · 2021-06-25T23:32:16Z

Congratulations 🎉. DeepCode analyzed your code in 2.246 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

phsft-bot · 2021-06-25T23:37:02Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-26T00:00:36Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-06-26T00:03:54Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_escapedQuotesreadTree

phsft-bot · 2021-06-26T00:10:58Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.genreflex.roottest_root_meta_genreflex_escapedQuotesreadTree

phsft-bot · 2021-06-26T00:41:07Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-26T03:20:39Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-06-26T03:20:38.151Z] LINK : fatal error LNK1104: cannot open file 'C:\build\workspace\root-pullrequests-build\build\bin\libCore.dll' [C:\build\workspace\root-pullrequests-build\build\core\Core.vcxproj]

phsft-bot · 2021-06-29T21:36:39Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-29T21:51:25Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-15T01:30:00Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-15T01:46:59Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-15T01:56:52Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2022-01-15T01:36:38.345Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-15T01:36:38.345Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/mathtext/src/table/adobeglyphlist.h:128:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-15T01:41:33.319Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:44: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]
[2022-01-15T01:41:33.319Z] /data/sftnight/workspace/root-pullrequests-build/root/graf2d/postscript/src/AdobeGlyphList.h:110:55: warning: unpaired UTF-8 bidirectional control character detected [-Wbidi-chars=]

Failing tests:

phsft-bot · 2022-01-15T02:41:41Z

Build failed on ROOT-ubuntu2004/soversion.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

phsft-bot · 2022-01-15T03:15:51Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 5 more

phsft-bot · 2022-01-15T05:06:46Z

Build failed on mac1015/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.cling.specialobj.roottest_cling_specialobj_runf02

pcanal · 2022-01-19T16:09:24Z

@phsft-bot build

phsft-bot · 2022-01-19T16:09:31Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-19T20:30:43Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

And 4 more

Extend the support for a rule that applies to several data members (and thus currently is applied as the 'object level') to the case of a split object embedded within a split subobject of an object (previous it worked only for the collection case). This fixes issue root-project#8428, see also https://cdcvs.fnal.gov/redmine/issues/25893.

tree/tree/src/TBranchElement.cxx

phsft-bot · 2022-01-26T16:45:31Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-26T18:24:39Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.tree.evolution.roottest_root_tree_evolution_make

phsft-bot · 2022-01-27T09:02:51Z

Build failed on mac11/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.tree.evolution.roottest_root_tree_evolution_make

…etion In the case where the containing object held several sub-object whose type is a class which has a 'whole object' rule, prior to this commit, the infrastructure would re-use only one of the incoming object as input to the rule executions.

…split obj. Use the full name to make branch name comparisons

The branch ID is not reliable as for the 'later' branch it has not yet been updated from the as-seen-when-writing value to the current value.

… for missing data member

phsft-bot · 2022-01-29T01:53:29Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2022-01-29T04:15:19Z

Build failed on mac11/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

pcanal requested a review from Axel-Naumann June 14, 2021 22:56

pcanal requested a review from jblomer June 14, 2021 22:56

pcanal self-assigned this Jun 14, 2021

pcanal added affects:master in:TTree priority:critical labels Jun 14, 2021

jblomer reviewed Jun 15, 2021

View reviewed changes

pcanal force-pushed the master-issue-8428 branch from 4424196 to 34b5ec5 Compare June 22, 2021 21:16

pcanal force-pushed the master-issue-8428 branch from 34b5ec5 to 17005fb Compare June 25, 2021 23:32

pcanal force-pushed the master-issue-8428 branch from 17005fb to 5d22b2d Compare June 25, 2021 23:36

pcanal force-pushed the master-issue-8428 branch from 5d22b2d to 78ca4af Compare June 26, 2021 00:41

pcanal force-pushed the master-issue-8428 branch from 78ca4af to 43e0362 Compare June 29, 2021 21:36

pcanal mentioned this pull request Jan 15, 2022

Fix the fix to #7754 (schema evolution in nested collections incl. TClonesArray) #9585

Merged

Axel-Naumann approved these changes Jan 25, 2022

View reviewed changes

pcanal force-pushed the master-issue-8428 branch from 66bd1ec to 6093325 Compare January 26, 2022 16:45

pcanal added 8 commits January 28, 2022 19:49

Further devel for extend io customization support: whole obj rule in …

a243d5a

…split obj. Use the full name to make branch name comparisons

In SetOnfileObject also determine the 'last' branch based on name.

2268c1e

The branch ID is not reliable as for the 'later' branch it has not yet been updated from the as-seen-when-writing value to the current value.

TBranchElement::InitializeOffsets: don't confuse top level collection…

332c993

… for missing data member

Add comment on semantic of fConfiguration->fElemId == -1

eb758d7

TBranchElement::Print add fOnfileObject to 'debugAddress'

ef9682c

TClass::GetRealData support more than one level of nesting

62b837f

[NFC] Typo in comment

ecc8548

pcanal force-pushed the master-issue-8428 branch from 6093325 to ecc8548 Compare January 29, 2022 01:53

pcanal mentioned this pull request Feb 1, 2022

v626: Extend io customization support: whole obj rule in split obj. #9771

Merged

pcanal merged commit c29e72e into root-project:master Feb 1, 2022

pcanal deleted the master-issue-8428 branch February 1, 2022 20:37

Conversation

pcanal commented Jun 14, 2021

Uh oh!

phsft-bot commented Jun 14, 2021

Uh oh!

pcanal commented Jun 14, 2021

Uh oh!

pcanal commented Jun 14, 2021

Uh oh!

phsft-bot commented Jun 14, 2021

Uh oh!

phsft-bot commented Jun 14, 2021

Failing tests:

Uh oh!

phsft-bot commented Jun 14, 2021

Errors:

Uh oh!

greenc-FNAL commented Jun 15, 2021

Uh oh!

jblomer left a comment

Choose a reason for hiding this comment

Uh oh!

phsft-bot commented Jun 22, 2021

Uh oh!

phsft-bot commented Jun 25, 2021

Uh oh!

ghost commented Jun 25, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

Uh oh!

phsft-bot commented Jun 25, 2021

Uh oh!

phsft-bot commented Jun 26, 2021

Failing tests:

Uh oh!

phsft-bot commented Jun 26, 2021

Failing tests:

Uh oh!

phsft-bot commented Jun 26, 2021

Failing tests:

Uh oh!

phsft-bot commented Jun 26, 2021

Uh oh!

phsft-bot commented Jun 26, 2021

Errors:

Uh oh!

phsft-bot commented Jun 29, 2021

Uh oh!

phsft-bot commented Jun 29, 2021

Uh oh!

phsft-bot commented Jan 15, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 15, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 15, 2022

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Jan 15, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 15, 2022

Failing tests:

Uh oh!

phsft-bot commented Jan 15, 2022

Failing tests:

Uh oh!

pcanal commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Uh oh!

phsft-bot commented Jan 19, 2022

Failing tests:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Jun 25, 2021 •

edited by ghost

Loading