v6.24: Fix for bulkio issue #6520#8403
Merged
pcanal merged 6 commits intoroot-project:v6-24-00-patchesfrom Jun 11, 2021
Merged
Conversation
Rename DeserializeType::kDestructive into DeserializeType::kExternal as it describe better the situation (the TBufferFile is not large enough to hold the deserialized data). Correct the value of GetDeserializeType for TLeafB, TLeafG, TLeafO, TLeafS in particular several where incorrectly marked as kExternal when part of an array (fLeafCount != nullptr); This fixes root-project#6520.
…licitly before hand
The user can always find a way to deserialize it. It might be as simple as byte swapping or might requires to call a full StreamerInfoAction sequence.
And resolve issue with floating point saturation in the input
|
Starting build on |
Contributor
|
Thank you for this. Can we have it merged? |
Member
Author
|
Yes, it was just waiting on the last CI build to finish ... :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the value of 'GetSerializedType'.