Skip to content

JupyROOT: fixed bug closing the file descriptors#8386

Merged
etejedor merged 1 commit intoroot-project:masterfrom
oprojects:kernel
Jun 10, 2021
Merged

JupyROOT: fixed bug closing the file descriptors#8386
etejedor merged 1 commit intoroot-project:masterfrom
oprojects:kernel

Conversation

@omazapa
Copy link
Copy Markdown
Contributor

@omazapa omazapa commented Jun 9, 2021

Hello!
This is a fix to close the file descriptors for stdout, stderr, and some pipes
capturing stdout and stderr for notebooks.

closes #8326

@omazapa omazapa requested a review from etejedor June 9, 2021 15:00
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@etejedor etejedor self-assigned this Jun 9, 2021
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

Copy link
Copy Markdown
Contributor

@etejedor etejedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @omazapa ! Looks good as discussed!

@etejedor etejedor merged commit 1acb202 into root-project:master Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jupyter + ROOT: too many open files

3 participants