Fix for bulkio issue #6520 by pcanal · Pull Request #8325 · root-project/root

pcanal · 2021-06-03T00:22:38Z

Correct the value of 'GetSerializedType'.

phsft-bot · 2021-06-03T00:22:54Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

tree/tree/src/TLeafElement.cxx

tree/tree/test/BulkApiMultiple.cxx

phsft-bot · 2021-06-08T15:23:55Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

Rename DeserializeType::kDestructive into DeserializeType::kExternal as it describe better the situation (the TBufferFile is not large enough to hold the deserialized data). Correct the value of GetDeserializeType for TLeafB, TLeafG, TLeafO, TLeafS in particular several where incorrectly marked as kExternal when part of an array (fLeafCount != nullptr); This fixes root-project#6520.

…licitly before hand

The user can always find a way to deserialize it. It might be as simple as byte swapping or might requires to call a full StreamerInfoAction sequence.

Axel-Naumann

No significant comments :-)

tree/tree/test/BulkApiMultiple.cxx

phsft-bot · 2021-06-08T18:10:05Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-06-08T18:09:59.818Z] LINK : fatal error LNK1104: cannot open file 'C:\build\workspace\root-pullrequests-build\build\bin\libCore.dll' [C:\build\workspace\root-pullrequests-build\build\core\Core.vcxproj]

phsft-bot · 2021-06-08T18:59:58Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-06-08T19:17:43Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

[2021-06-08T19:17:36.064Z] FAILED: tree/tree/test/CMakeFiles/testBulkApiMultiple.dir/BulkApiMultiple.cxx.o
[2021-06-08T19:17:36.662Z] /build/jenkins/workspace/root-pullrequests-build/root/tree/tree/test/BulkApiMultiple.cxx:15:27: error: constexpr variable 'gRollOver' must be initialized by a constant expression

phsft-bot · 2021-06-08T21:29:24Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

tree/tree/test/BulkApiMultiple.cxx

And resolve issue with floating point saturation in the input

…case

phsft-bot · 2021-06-09T22:52:46Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

pcanal requested review from Axel-Naumann and bbockelm June 3, 2021 00:22

pcanal self-assigned this Jun 3, 2021

pcanal linked an issue Jun 3, 2021 that may be closed by this pull request

Integer types not available for Bulk API #6520

Closed

Axel-Naumann reviewed Jun 8, 2021

View reviewed changes

tree/tree/src/TLeafElement.cxx Outdated Show resolved Hide resolved

Axel-Naumann reviewed Jun 8, 2021

View reviewed changes

tree/tree/test/BulkApiMultiple.cxx Outdated Show resolved Hide resolved

Axel-Naumann reviewed Jun 8, 2021

View reviewed changes

tree/tree/test/BulkApiMultiple.cxx Show resolved Hide resolved

pcanal force-pushed the master-bulkio-6520 branch from 5d90323 to f678a24 Compare June 8, 2021 15:23

pcanal added 4 commits June 8, 2021 10:24

ReadBasketFast no longer required GetDeserializeType to be called exp…

3f11d3b

…licitly before hand

Extend BulkApiMultiple test to more data type

b11a98a

Always accept to return the serialized buffer.

1d28dff

The user can always find a way to deserialize it. It might be as simple as byte swapping or might requires to call a full StreamerInfoAction sequence.

Axel-Naumann approved these changes Jun 8, 2021

View reviewed changes

pcanal force-pushed the master-bulkio-6520 branch from f678a24 to 871f37f Compare June 8, 2021 18:59

pcanal force-pushed the master-bulkio-6520 branch from 871f37f to ec43838 Compare June 8, 2021 21:29