Skip to content

[rntuple] Factor out common code in the sealed pages path and add support for sealed pages to DAOS#8309

Merged
jalopezg-git merged 2 commits intoroot-project:masterfrom
jalopezg-git:jalopezg-rntupledaos-sealedpages
Jun 3, 2021
Merged

[rntuple] Factor out common code in the sealed pages path and add support for sealed pages to DAOS#8309
jalopezg-git merged 2 commits intoroot-project:masterfrom
jalopezg-git:jalopezg-rntupledaos-sealedpages

Conversation

@jalopezg-git
Copy link
Copy Markdown
Contributor

@jalopezg-git jalopezg-git commented Jun 1, 2021

First, this PR factors out common parts of the code in commit/load of (sealed) pages. Specifically, this affects:

  • CommitPageImpl and CommitSealedPageImpl.
  • PopulatePageFromCluster() and LoadSealedPage(). Locating the RPageInfo from the cluster index is now a member function of RPageRange.

Second, it provides support for sealed pages in the DAOS backend.

Closes issue #8079.

@jalopezg-git jalopezg-git requested a review from jblomer June 1, 2021 12:11
@jalopezg-git jalopezg-git self-assigned this Jun 1, 2021
@jalopezg-git jalopezg-git requested a review from pcanal as a code owner June 1, 2021 12:11
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 1, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jalopezg-git jalopezg-git linked an issue Jun 1, 2021 that may be closed by this pull request
[ntuple, daos] Implement reading and writing of sealed pages #8079
Closed
jblomer
jblomer requested changes Jun 2, 2021
View reviewed changes
@jalopezg-git jalopezg-git force-pushed the jalopezg-rntupledaos-sealedpages branch from 53da2b1 to 5984cea Compare June 2, 2021 12:11
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 2, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 2, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-06-02T12:18:50.956Z] /home/sftnight/build/workspace/root-pullrequests-build/root/tree/ntuple/v7/src/RNTupleDescriptor.cxx:477:58: error: no matching function for call to ‘ROOT::Experimental::RClusterDescriptor::RPageRange::RPageInfoExtended::RPageInfoExtended(<brace-enclosed initializer list>)’

@jalopezg-git jalopezg-git force-pushed the jalopezg-rntupledaos-sealedpages branch from 5984cea to 2f632fe Compare June 2, 2021 12:46
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 2, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jalopezg-git
Copy link
Copy Markdown
Contributor Author

jalopezg-git commented Jun 2, 2021

Oops! Sorry for the noise; should be ready to merge now. :-)

jblomer
jblomer requested changes Jun 3, 2021
View reviewed changes
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 3, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jalopezg-git
[ntuple] Factor out common code used in the commit/load of pages
d626a2b 
Parts of the code to commit/load pages is used in the sealed pages path. Factor
this out.  Specifically, this affects common code in:
- `CommitPageImpl` and `CommitSealedPageImpl`.
- `PopulatePageFromCluster()` and `LoadSealedPage()`. Locating the RPageInfo
from the cluster index is now a member function of RPageRange.
@jalopezg-git
[ntuple,daos] Support load/store of sealed pages in DAOS
d9d04a3
@jalopezg-git jalopezg-git force-pushed the jalopezg-rntupledaos-sealedpages branch from a9006da to d9d04a3 Compare June 3, 2021 12:45
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Jun 3, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@jalopezg-git jalopezg-git merged commit 8bff692 into root-project:master Jun 3, 2021
@jalopezg-git jalopezg-git deleted the jalopezg-rntupledaos-sealedpages branch June 3, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jblomer jblomer jblomer approved these changes

@pcanal pcanal Awaiting requested review from pcanal

Assignees

@jalopezg-git jalopezg-git

Labels

improvement in:RNTuple

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ntuple, daos] Implement reading and writing of sealed pages

3 participants

@jalopezg-git @phsft-bot @jblomer