Use string(FIND) instead of regex for matching directory names#8306
Merged
oshadura merged 4 commits intoroot-project:masterfrom Jun 3, 2021
Merged
Use string(FIND) instead of regex for matching directory names#8306oshadura merged 4 commits intoroot-project:masterfrom
oshadura merged 4 commits intoroot-project:masterfrom
Conversation
> git clone [email protected]:SpectreVert/root.git root_src+tag > cd root_src+tag > mkdir compiled && cd compiled && cmake .. # should work as intented now
|
Starting build on |
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Collaborator
|
Retry DeepCode |
oshadura
approved these changes
Jun 3, 2021
Collaborator
oshadura
left a comment
oshadura
left a comment
There was a problem hiding this comment.
LGTM! it nicely simplifies code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8305
5 places in RootMacros.cmake use regex when a simple string(FIND) suffices