[PyROOT][8183] Do not increment STL-like iterator in first iteration#8282
Merged
etejedor merged 1 commit intoroot-project:masterfrom May 31, 2021
Merged
[PyROOT][8183] Do not increment STL-like iterator in first iteration#8282etejedor merged 1 commit intoroot-project:masterfrom
etejedor merged 1 commit intoroot-project:masterfrom
Conversation
This fixes the iteration over a TTreeReader, since incrementing its iterator before the loop body of the first iteration runs causes the current entry of the reader to always be one position ahead. From: https://bitbucket.org/wlav/cpycppyy/commits/8222848093bd687d67f2b89172764e0964cb14f0
|
Starting build on |
DeepCode's analysis on #9613dd found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
eguiraud
approved these changes
May 31, 2021
Contributor
eguiraud
left a comment
eguiraud
left a comment
There was a problem hiding this comment.
I don't really understand the changes, but if they make root-project/roottest#708 green that's ok with me 😄
|
Build failed on windows10/cxx14. Failing tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the iteration over a TTreeReader, since incrementing its
iterator before the loop body of the first iteration runs causes
the current entry of the reader to always be one position ahead.
From:
https://bitbucket.org/wlav/cpycppyy/commits/8222848093bd687d67f2b89172764e0964cb14f0
Fixes #8183