Skip to content

[PyROOT][8128] Fixes for Python3.9#8257

Merged
etejedor merged 1 commit intoroot-project:masterfrom
etejedor:py39
May 28, 2021
Merged

[PyROOT][8128] Fixes for Python3.9#8257
etejedor merged 1 commit intoroot-project:masterfrom
etejedor:py39

Conversation

@etejedor
Copy link
Copy Markdown
Contributor

Fixes #8128

@etejedor etejedor requested a review from eguiraud May 27, 2021 07:25
@etejedor etejedor self-assigned this May 27, 2021
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora32/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

Build failed on ROOT-fedora32/noimt.
Running on root-fedora32-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

  • [2021-05-27T07:28:56.649Z] math/unuran/unuran-1.8.0-root/src/methods/mvtdr_init.ch:886:17: warning: argument 1 value ‘18446744073709551608’ exceeds maximum object size 9223372036854775807 [-Walloc-size-larger-than=]

Failing tests:

Copy link
Copy Markdown
Contributor

@eguiraud eguiraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Why some of the changes of the upstream patch rather than all of them (if relevant for the future, might be nice to add that info to the commit message)

@etejedor
Copy link
Copy Markdown
Contributor Author

LGTM! Why some of the changes of the upstream patch rather than all of them (if relevant for the future, might be nice to add that info to the commit message)

Thanks! There's some changes in that patch that are not strictly related to Python3.9, and also I added more changes needed for our PyROOT / TPython files - at least it will stay written here!

@etejedor
Copy link
Copy Markdown
Contributor Author

Test failures are unrelated to these changes, merging.

@etejedor etejedor merged commit 9aa67a8 into root-project:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Many warnings coming from cppyy with Python 3.9

3 participants