Skip to content

[io] Accelerate TDirectoryFile::GetObjectChecked (NFCI):#8249

Merged
Axel-Naumann merged 1 commit intoroot-project:masterfrom
Axel-Naumann:TDirFile_GetObjChecked_NoIter
May 27, 2021
Merged

[io] Accelerate TDirectoryFile::GetObjectChecked (NFCI):#8249
Axel-Naumann merged 1 commit intoroot-project:masterfrom
Axel-Naumann:TDirFile_GetObjChecked_NoIter

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann commented May 26, 2021

Fix issue #8046 by only iterating the bucket that corresponds to the object name.

@Axel-Naumann Axel-Naumann requested a review from pcanal May 26, 2021 13:14
@Axel-Naumann Axel-Naumann self-assigned this May 26, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@Axel-Naumann Axel-Naumann force-pushed the TDirFile_GetObjChecked_NoIter branch from 7d9753d to c836d6d Compare May 26, 2021 14:35
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

pcanal
pcanal reviewed May 26, 2021
View reviewed changes
@Axel-Naumann
[io] Accelerate TDirectoryFile::GetObjectChecked (NFCI):
fa69207 
Fix issue root-project#8046 by only iterating the bucket that corresponds to the object name.
@Axel-Naumann Axel-Naumann force-pushed the TDirFile_GetObjChecked_NoIter branch from c836d6d to fa69207 Compare May 26, 2021 15:07
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann merged commit 524110c into root-project:master May 27, 2021
@Axel-Naumann Axel-Naumann deleted the TDirFile_GetObjChecked_NoIter branch May 27, 2021 07:02
@Axel-Naumann Axel-Naumann linked an issue May 27, 2021 that may be closed by this pull request
TDirectory::GetObject is needlessly slow #8046
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TDirectory::GetObject is needlessly slow

3 participants

@Axel-Naumann @phsft-bot @pcanal