Allow standards-based attributes to have leading and trailing underscores.#8243
Merged
Axel-Naumann merged 1 commit intoroot-project:masterfrom May 27, 2021
Conversation
…ores. This gives library implementers a way to use standards-based attributes that do not conflict with user-defined macros of the same name. Attributes in C2x require this behavior normatively (C2x 6.7.11p4), but there's no reason to not have the same behavior in C++, especially given that such attributes may be used by a C library consumed by a C++ compilation. llvm-svn: 369033
|
Starting build on |
vgvassilev
approved these changes
May 26, 2021
Member
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
That was exactly what I was looking for. Thanks!
pcanal
approved these changes
May 26, 2021
Axel-Naumann
deleted the
clang-attr-double_underscore-2ed4573e8f8619dc67647256ac070bf91f461392
branch
Axel-Naumann
restored the
clang-attr-double_underscore-2ed4573e8f8619dc67647256ac070bf91f461392
branch
Axel-Naumann
deleted the
clang-attr-double_underscore-2ed4573e8f8619dc67647256ac070bf91f461392
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives library implementers a way to use standards-based attributes that do not conflict with user-defined macros of the same name. Attributes in C2x require this behavior normatively (C2x 6.7.11p4), but there's no reason to not have the same behavior in C++, especially given that such attributes may be used by a C library consumed by a C++ compilation.
llvm-svn: 369033
Backported from llvm-project 2ed4573e8f8619dc67647256ac070bf91f461392
Fixes GCC 11 builds.