[ntuple, daos] Enable RNTuple DAOS unit tests if -Dtesting=ON#8094
Merged
jalopezg-git merged 2 commits intoroot-project:masterfrom May 7, 2021
Merged
Conversation
|
Starting build on |
Contributor
Author
|
Note that #8093 is to be merged first, which should avoid the above test failures. |
|
Build failed on windows10/cxx14. Errors:
|
|
Build failed on mac11.0/cxx17. Warnings:
And 1512 more Failing tests:
And 13 more |
oshadura
approved these changes
May 5, 2021
Collaborator
oshadura
left a comment
oshadura
left a comment
There was a problem hiding this comment.
Small wording suggestion, otherwise LGTM!
jalopezg-git
force-pushed
the
jalopezg-daos_mock-testing
branch
from
873bde9 to
8f86ba2
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
Contributor
Author
@oshadura I think that we should also disable |
|
Build failed on mac11.0/cxx17. Warnings:
And 5 more Failing tests:
And 13 more |
jalopezg-git
force-pushed
the
jalopezg-daos_mock-testing
branch
from
8f86ba2 to
052a2a1
Compare
|
Starting build on |
|
Build failed on mac11.0/cxx17. Warnings:
And 5 more |
|
Build failed on windows10/cxx14. Errors:
|
Contributor
Author
|
@phsft-bot build |
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
Build failed on mac11.0/cxx17. Warnings:
And 1512 more Failing tests:
|
In order to enable RNTuple DAOS unit tests, RNTuple is built with libdaos_mock if `testing` is set and the user did not enable explicit DAOS support, i.e. `-Ddaos=ON`. This allows for testing the DAOS backend in an environment that lacks a real DAOS deployment. Note that this is disabled for Windows, as both `libdaos` and `libdaos_mock` depend on libuuid (which is not tipically there on these platforms).
jalopezg-git
force-pushed
the
jalopezg-daos_mock-testing
branch
from
052a2a1 to
0778a94
Compare
|
Starting build on |
- [-Wunused-parameter] warning in `daos_obj_generate_id()` function. - [-Wextern-c-compat]: empty structures are not allowed by C99; GNU C extensions and ISO C++ take it as if it had one `char` member, so that the address of different objects is also different. Therefore, a member of type `char` has been added so that the struct layout is the same in C and C++.
jalopezg-git
force-pushed
the
jalopezg-daos_mock-testing
branch
from
0778a94 to
f8c2ea1
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
|
jblomer
approved these changes
May 7, 2021
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to enable RNTuple DAOS unit tests, RNTuple is built with libdaos_mock
if
testingis set and the user did not enable explicit DAOS support, i.e.-Ddaos=ON.Closes issue #8074.