[ntuple, daos] Defer daos_init() call until needed#8093
Merged
jalopezg-git merged 1 commit intoroot-project:masterfrom May 6, 2021
Merged
Conversation
|
Starting build on |
Contributor
Author
|
@phsft-bot build |
|
Starting build on |
jalopezg-git
force-pushed
the
jalopezg-rntuple-daos-deferinit
branch
from
901165d to
f407c8b
Compare
|
Starting build on |
pcanal
reviewed
May 6, 2021
The RAII object in RDaos.cxx was constructed statically, which causes a DAOS-enabled RNTuple build to call `daos_init()` (or `daos_fini()` at exit) even if the only the file backend was used by user code. This commit turns the RAII object into a static variable in `RDaosPool::RDaosPool()` which is initialized during the first call to the constructor. Note that static variable initialization is guaranteed to be thread-safe by ISO C++.
jalopezg-git
force-pushed
the
jalopezg-rntuple-daos-deferinit
branch
from
f407c8b to
a7eff46
Compare
|
Starting build on |
pcanal
approved these changes
May 6, 2021
|
Build failed on mac11.0/cxx17. Warnings:
And 1475 more Failing tests:
|
|
Build failed on windows10/cxx14. Errors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RAII object in RDaos.cxx was constructed statically, which causes a DAOS-enabled RNTuple build to call
daos_init()(ordaos_fini()at exit) even if the only the file backend was used by user code.This commit turns the RAII object into a static variable in
RDaosPool::RDaosPool()which is initialized during the first call to theconstructor. Note that static variable initialization is guaranteed to be thread-safe by ISO C++.