[JupyROOT][8055] Make poller thread a daemon#8081
Merged
etejedor merged 1 commit intoroot-project:masterfrom May 4, 2021
Merged
[JupyROOT][8055] Make poller thread a daemon#8081etejedor merged 1 commit intoroot-project:masterfrom
etejedor merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests:
|
As explained in 8055, it can otherwise keep a process spawned from the kernel process from finishing.
|
Build failed on mac11.0/cxx17. Warnings:
And 1475 more Failing tests:
|
etejedor
force-pushed
the
pollerthreaddaemon
branch
from
9925d2a to
7701b88
Compare
|
Starting build on |
|
Build failed on mac11.0/cxx17. Warnings:
And 1475 more Failing tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8055