Skip to content

[thread] remove TReentrantRWLock.hxx from public includes#8034

Merged
linev merged 1 commit intoroot-project:masterfrom
linev:thread_rwlock
Apr 29, 2021
Merged

[thread] remove TReentrantRWLock.hxx from public includes#8034
linev merged 1 commit intoroot-project:masterfrom
linev:thread_rwlock

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Apr 29, 2021

It is implementation details, using TBB.
To be able use it as public include, one should provide
proper INCLUDES and CXX_FLAGS settings for Thread library

Resolves #8022

@linev
[thread] remove TReentrantRWLock.hxx from public includes
9ef51e8 
It is implementation details, using TBB.
To be able use it as public include, one should provide
proper INCLUDES and CXX_FLAGS settings for Thread library
@linev linev requested a review from pcanal April 29, 2021 07:04
@linev linev self-assigned this Apr 29, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

@linev
Copy link
Copy Markdown
Member Author

linev commented Apr 29, 2021

All builds are fine up to now - just uploading of results fails 👎

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 29, 2021

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

@linev linev merged commit 0f14430 into root-project:master Apr 29, 2021
@linev linev deleted the thread_rwlock branch April 29, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann

+1 more reviewer

@oshadura oshadura oshadura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@linev linev

Labels

affects:master improvement in:Core Libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TBB exposed in public includes of Thread library

4 participants

@linev @phsft-bot @pcanal @oshadura