[v624] Properly handle v5 file with missing information.#7990
Merged
pcanal merged 1 commit intoroot-project:v6-24-00-patchesfrom Apr 27, 2021
Merged
Conversation
Fix root-project#7912. In this report, the v5 file has a 'map<TString, RooExpensiveObjectCache::ExpensiveObject*>' however it is recorded as 'map<TString, ExpensiveObject*>'. However the map stored in the file is empty and thus no information was recorded about `ExpensiveObject`, consequently when the map's StreamerInfo request the TClass for the underlying pair, it is returned nullptr (since we no longer create the TClass for a pair where one or more of the component is unknown). The routine `FixCollectionV5` needed to be updated to handle this situation.
|
Starting build on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #7912.
In this report, the v5 file has a 'map<TString, RooExpensiveObjectCache::ExpensiveObject*>'
however it is recorded as 'map<TString, ExpensiveObject*>'. However the map stored in
the file is empty and thus no information was recorded about
ExpensiveObject,consequently when the map's StreamerInfo request the TClass for the underlying pair,
it is returned nullptr (since we no longer create the TClass for a pair where one or
more of the component is unknown).
The routine
FixCollectionV5needed to be updated to handle this situation.