Make sure roottest tests ROOT being build, not ROOT in env#7937
Make sure roottest tests ROOT being build, not ROOT in env#7937Axel-Naumann merged 1 commit intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Failing tests: |
|
Build failed on mac1014/python3. Failing tests: |
CMakeLists.txt
Outdated
| if(IS_DIRECTORY ${roottestdir}) | ||
| file(REMOVE_RECURSE ${CMAKE_CURRENT_BINARY_DIR}/roottest) | ||
| add_subdirectory(${roottestdir} roottest) | ||
| add_subdirectory(${roottestdir} roottest-build) |
There was a problem hiding this comment.
Why we have here roottest-build?
There was a problem hiding this comment.
It's the build directory that's passed as the second argument. And I was always confused why I checked out roottest into my build dir ;-) I prefer to have the directory name clarify it's the roottest build dir. I'm okay to drop this if you find this wrong!
There was a problem hiding this comment.
nono, I was just curious...Let's use it!
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on ROOT-fedora30/cxx14. Failing tests: |
|
Build failed on windows10/cxx14. Errors:
And 8 more |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on ROOT-debian10-i386/cxx14. Failing tests: |
|
Build failed on mac11.0/cxx17. Failing tests: |
|
@Axel-Naumann |
Totally - debugging... |
This fixes issue-7081, as now, with the correct spelling of the env var, the build-ROOTSYS is picked up by roottest.
d209bb6 to
7f41301
Compare
|
Starting build on |
|
|
Fixes #7081