[IO] Fix out of bounds read in TClassEdit#7920
Merged
eguiraud merged 1 commit intoroot-project:masterfrom Apr 20, 2021
Merged
Conversation
|
Starting build on |
hageboeck
approved these changes
Apr 19, 2021
Member
hageboeck
left a comment
hageboeck
left a comment
There was a problem hiding this comment.
This will fix the current bug. What I'm not sure about is whether there might be more cases that have to be handled?
Contributor
Author
|
We test RVec I/O and it works. Unless Philippe knows off the top of his head, we'll fix other bugs when we encounter them. |
pcanal
reviewed
Apr 19, 2021
pcanal
approved these changes
Apr 19, 2021
|
Build failed on mac11.0/cxx17. Errors:
|
eguiraud
force-pushed
the
fix_outofbounds_read
branch
from
f821720 to
031146e
Compare
|
Starting build on |
|
Build failed on ROOT-fedora31/noimt. Warnings:
|
|
Build failed on ROOT-fedora30/cxx14. Warnings:
|
|
Build failed on mac1014/python3. Warnings:
|
|
Build failed on ROOT-ubuntu16/nortcxxmod. Warnings:
|
|
Build failed on ROOT-performance-centos8-multicore/default. Warnings:
|
pcanal
reviewed
Apr 19, 2021
pcanal
approved these changes
Apr 19, 2021
|
Build failed on ROOT-debian10-i386/cxx14. Warnings:
|
|
Build failed on mac11.0/cxx17. Warnings:
|
When doing I/O of RVec objects, TClassEdit::STLArgs was accessing an element one after the end of a static array. asan rightly complains. This commit fixes root-project#7903, which contains more details.
eguiraud
force-pushed
the
fix_outofbounds_read
branch
from
031146e to
6e30d2d
Compare
|
Starting build on |
|
Build failed on windows10/cxx14. Errors:
And 50 more |
Contributor
Author
|
Windows failure is unrelated, I finally got it right, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing I/O of RVec objects, TClassEdit::STLArgs was accessing
an element one after the end of a static array. asan rightly complains.
This commit fixes #7903,
which contains more details.