Skip to content

Remove memstat, memcheck; keep objstat:#7867

Merged
Axel-Naumann merged 1 commit intoroot-project:masterfrom
Axel-Naumann:rm-memstat
Jun 15, 2021
Merged

Remove memstat, memcheck; keep objstat:#7867
Axel-Naumann merged 1 commit intoroot-project:masterfrom
Axel-Naumann:rm-memstat

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann commented Apr 14, 2021

These facilities are superseded by valgrind and other memory checkers.
memstat has been deprecated since v6.18.

Big questions I didn't answer yet:

  • do we still need TStorage?
  • do we need to deprecate the removed TApplication interfaces?

@Axel-Naumann Axel-Naumann requested a review from pcanal April 14, 2021 08:29
@Axel-Naumann Axel-Naumann self-assigned this Apr 14, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T08:43:57.275Z] collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T08:45:14.631Z] FAILED: bin/rootn.exe
  • [2021-04-14T08:45:14.631Z] clang: error: linker command failed with exit code 1 (use -v to see invocation)

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T08:45:44.653Z] FAILED: bin/rootn.exe
  • [2021-04-14T08:45:44.653Z] collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T08:46:54.301Z] FAILED: : && /usr/bin/c++ -fdiagnostics-color=always -std=c++11 -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fvisibility=hidden -fno-strict-aliasing -Wwrite-strings -Wno-shadow -Wno-unused-parameter -Wno-deprecated-declarations -O3 -rdynamic -Wl,--no-as-needed main/CMakeFiles/rootn.exe.dir/src/rmain.cxx.o -o bin/rootn.exe -Wl,-rpath,/mnt/build/workspace/root-pullrequests-build/build/lib: -lNew lib/libMathCore.so.6.25.01 lib/libRint.so.6.25.01 lib/libImt.so.6.25.01 lib/libMultiProc.so.6.25.01 lib/libNet.so.6.25.01 lib/libRIO.so.6.25.01 lib/libThread.so.6.25.01 -lpthread lib/libCore.so.6.25.01 && :
  • [2021-04-14T08:46:54.301Z] collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T08:50:01.639Z] collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T09:36:30.419Z] collect2: error: ld returned 1 exit status

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Apr 14, 2021

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-04-14T12:58:03.912Z] FAILED: core/thread/G__Thread.cxx lib/Thread.pcm
  • [2021-04-14T12:58:04.483Z] /Users/sftnight/build/workspace/root-pullrequests-build/build/include/ROOT/TReentrantRWLock.hxx:26:10: fatal error: 'tbb/enumerable_thread_specific.h' file not found

@pcanal
Copy link
Copy Markdown
Member

pcanal commented Apr 14, 2021

do we still need TStorage?

It looks like we don't. We might want to deprecate it and remove its internal use.

do we need to deprecate the removed TApplication interfaces?

It would probably be nicer but in this case, it looks like those are very few.

pcanal
pcanal reviewed Apr 14, 2021
View reviewed changes
core/CMakeLists.txt
endif()

if(NOT WIN32)
add_subdirectory(newdelete)
Copy link
Copy Markdown
Member

@pcanal pcanal Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newdelete is not just for memstate, it is also for the shared memory thingy.

@Axel-Naumann Axel-Naumann linked an issue May 11, 2021 that may be closed by this pull request
Without memstat support, root -memstat should not be available #6410
Closed
@Axel-Naumann
[core] Remove long-deprecated memstat, memcheck:
d72d3e4 
These facilities are superseded by valgrind and other memory checkers.
memstat has been deprecated since v6.18.

Keep objstat.
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented May 26, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann marked this pull request as ready for review June 15, 2021 10:58
@Axel-Naumann Axel-Naumann merged commit 1f68735 into root-project:master Jun 15, 2021
@Axel-Naumann Axel-Naumann deleted the rm-memstat branch June 15, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

@couet couet Awaiting requested review from couet couet is a code owner

@oshadura oshadura Awaiting requested review from oshadura

Assignees

@Axel-Naumann Axel-Naumann

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Without memstat support, root -memstat should not be available

3 participants

@Axel-Naumann @phsft-bot @pcanal