[DF] Add GetDataSetInfo function by stwunsch · Pull Request #7833 · root-project/root

stwunsch · 2021-04-12T13:33:50Z

Fixes #7829 partially, missing integration into Describe

phsft-bot · 2021-04-12T13:33:57Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-12T14:16:17Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-12T14:29:05Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-12T14:47:25Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-12T15:00:06Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-12T15:41:48Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-12T18:27:49Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.meta.roottest_root_meta_runMemberComments

eguiraud · 2021-04-15T07:13:00Z

As per our discussion we'd like this method to report a bit more, namely anything that is useful to answer "what data is this RDF running on?", so e.g. both tree name and file names should be mentioned

phsft-bot · 2021-04-16T08:03:28Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-16T08:18:20Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_interface

phsft-bot · 2021-04-16T08:27:32Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_interface

phsft-bot · 2021-04-16T08:29:10Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_interface

phsft-bot · 2021-04-16T08:38:38Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_interface

phsft-bot · 2021-04-16T09:37:34Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.tree.dataframe.test.gtest_tree_dataframe_test_dataframe_interface

phsft-bot · 2021-04-16T10:16:22Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

eguiraud

Looks great, thanks @stwunsch !

tree/dataframe/inc/ROOT/RDF/RInterface.hxx

stwunsch · 2021-04-20T15:19:16Z

Note to myself: Add this to the RDF cheat sheet and the release notes.

phsft-bot · 2021-04-21T09:00:06Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-21T09:00:19Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:00:19.085Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:01:07Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:01:05.959Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:01:12Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:01:11.563Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:01:17Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:01:15.973Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:01:40Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:01:39.283Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:04:44Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:04:42.343Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:14:37Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:14:36.641Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T09:51:06Z

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T09:51:05.526Z] CMake Error at /build/jenkins/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:02:00Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-21T10:02:16Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:02:15.782Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:02:26Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:02:25.313Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:03:04Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:03:03.732Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:03:11Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:03:10.718Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:03:24Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:03:23.695Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:03:44Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:03:42.903Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:04:11Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:04:09.807Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

phsft-bot · 2021-04-21T10:06:24Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-04-21T10:06:23.184Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1026 (message):

Fixes root-project#7829 partially, missing integration into Describe

Fixes root-project#7829 finally

phsft-bot · 2021-04-21T14:51:38Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

stwunsch requested a review from eguiraud as a code owner April 12, 2021 13:33

lmoneta assigned stwunsch Apr 12, 2021

stwunsch mentioned this pull request Apr 15, 2021

[DF] Add GetDataSourceInfo function #7832

Closed

stwunsch force-pushed the df-datasetinfo branch from 4504de2 to 2eec683 Compare April 16, 2021 08:03

stwunsch force-pushed the df-datasetinfo branch from 2eec683 to dc066db Compare April 16, 2021 10:16

eguiraud approved these changes Apr 20, 2021

View reviewed changes

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

stwunsch force-pushed the df-datasetinfo branch from dc066db to 5de3ef8 Compare April 21, 2021 08:59

stwunsch force-pushed the df-datasetinfo branch from 5de3ef8 to e1065b6 Compare April 21, 2021 10:01

stwunsch requested a review from couet as a code owner April 21, 2021 10:01

stwunsch added 3 commits April 21, 2021 16:50

[DF] Add DescribeDataset function

cad60c5

Fixes root-project#7829 partially, missing integration into Describe

[DF][NFC] Use correct number for Describe tutorial

1787897

[DF] Add output of DescribeDataset on top of Describe

caba9a7

Fixes root-project#7829 finally

stwunsch force-pushed the df-datasetinfo branch from e1065b6 to caba9a7 Compare April 21, 2021 14:51

stwunsch removed the request for review from couet April 21, 2021 14:51

stwunsch merged commit 5191da2 into root-project:master Apr 21, 2021

Conversation

stwunsch commented Apr 12, 2021

Uh oh!

phsft-bot commented Apr 12, 2021

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 12, 2021

Failing tests:

Uh oh!

eguiraud commented Apr 15, 2021

Uh oh!

phsft-bot commented Apr 16, 2021

Uh oh!

phsft-bot commented Apr 16, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 16, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 16, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 16, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 16, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 16, 2021

Uh oh!

eguiraud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stwunsch commented Apr 20, 2021

Uh oh!

phsft-bot commented Apr 21, 2021

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Errors:

Uh oh!

phsft-bot commented Apr 21, 2021

Uh oh!

phsft-bot commented Apr 21, 2021