Skip to content

Fix the action PushDataCache for TClonesArray.#7755

Merged
pcanal merged 1 commit intoroot-project:masterfrom
pcanal:v626-7754
Mar 31, 2021
Merged

Fix the action PushDataCache for TClonesArray.#7755
pcanal merged 1 commit intoroot-project:masterfrom
pcanal:v626-7754

Conversation

@pcanal
Copy link
Copy Markdown
Member

@pcanal pcanal commented Mar 31, 2021

It was using the wrong signature leading to the configuration to be mis-read.

Fixes #7754

@pcanal
Fix the action PushDataCache for TClonesArray.
cec8c1a 
It was using the wrong signature leading to the configuration to be mis-read.

Fixes root-project#7754
@pcanal pcanal requested a review from Axel-Naumann March 31, 2021 00:38
@pcanal pcanal self-assigned this Mar 31, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 31, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@pcanal
Copy link
Copy Markdown
Member Author

pcanal commented Mar 31, 2021

@phsft-bot build with flags -DCTEST_TEST_EXCLUDE_NONE=On

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 31, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14 with flags -DCTEST_TEST_EXCLUDE_NONE=On
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 31, 2021

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

Axel-Naumann
Axel-Naumann approved these changes Mar 31, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Axel-Naumann Axel-Naumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure likely unrelated

@pcanal pcanal merged commit 875e8fb into root-project:master Mar 31, 2021
@pcanal pcanal deleted the v626-7754 branch March 31, 2021 21:28
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 31, 2021

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-03-31T22:47:39.227Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Axel-Naumann approved these changes

Assignees

@pcanal pcanal

Labels

affects:master in:I/O

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault when using schema evolution

3 participants

@pcanal @phsft-bot @Axel-Naumann