[cppyy] fix potential double deletion of memory in CPPMethod#7695
Merged
linev merged 1 commit intoroot-project:masterfrom Apr 16, 2021
Merged
[cppyy] fix potential double deletion of memory in CPPMethod#7695linev merged 1 commit intoroot-project:masterfrom
linev merged 1 commit intoroot-project:masterfrom
Conversation
After use of asign operator some fields can be destroyed twice
|
Starting build on |
linev
changed the title
Member
Author
|
Same problem exists in pyroot_lagcy/src/TMethodHolder.cxx, |
|
Build failed on mac11.0/cxx17. Failing tests: |
etejedor
approved these changes
Apr 16, 2021
Contributor
etejedor
left a comment
etejedor
left a comment
There was a problem hiding this comment.
Thank you @linev , fix is also already in upstream cppyy:
https://bitbucket.org/wlav/cpycppyy/commits/226559294b8855e5c12b59c19260d59dd943e36c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After use of assign operator some fields can be destroyed twice
Fixes #7692
Indirectly discovered via DeepCode