Skip to content

[cmake] Fix gtest options for gcc9 and old CMake#7667

Merged
oshadura merged 1 commit intoroot-project:masterfrom
mxxo:fix-cmake310
Mar 24, 2021
Merged

[cmake] Fix gtest options for gcc9 and old CMake#7667
oshadura merged 1 commit intoroot-project:masterfrom
mxxo:fix-cmake310

Conversation

@mxxo
Copy link
Copy Markdown
Contributor

@mxxo mxxo commented Mar 24, 2021

Using target_compile_options to set INTERFACE items on IMPORTED targets
is only supported in cmake 3.11 and up (see similar PR #5396). Reported in issue #7654.

Using target_compile_options to set INTERFACE items on IMPORTED targets
is only supported in cmake 3.11 and up (see similar PR root-project#5396).
@mxxo mxxo requested a review from oshadura March 24, 2021 14:59
@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@oshadura oshadura self-assigned this Mar 24, 2021
@oshadura oshadura linked an issue Mar 24, 2021 that may be closed by this pull request
1 task
@oshadura
Copy link
Copy Markdown
Collaborator

@phsft-bot build!

@phsft-bot
Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

Copy link
Copy Markdown
Collaborator

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oshadura
Copy link
Copy Markdown
Collaborator

Thanks a lot for a fix! Failure is unrelated, merging!

@oshadura oshadura merged commit 7a642f9 into root-project:master Mar 24, 2021
@mxxo mxxo deleted the fix-cmake310 branch March 25, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails with gcc 9 and CMake < 3.11

3 participants