Address several RooFit issues found by clang-tidy#7642
Merged
linev merged 9 commits intoroot-project:masterfrom Mar 22, 2021
Merged
Address several RooFit issues found by clang-tidy#7642linev merged 9 commits intoroot-project:masterfrom
linev merged 9 commits intoroot-project:masterfrom
Conversation
Delete m_pimpl with non-empty reference counter And (that is more probable) do not delete container when no other reference were existing
Only if getRange return kFALSE (which is OK), one can assign values for histogram binning
It will be nullptr or undefined. Use value to which it was move
It is not legal syntax to declare array like: RooLinkedListElem * arr[sz]; Instead use std::vector<RooLinkedListElem *> arr(sz, nullptr); Have to work on all platforms
|
Starting build on |
Member
Author
|
Last PR, which closes for me #7536 |
guitargeek
approved these changes
Mar 22, 2021
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Thanks for structuring your fixes in several commits! That made it easy to review and all your fixes look correct to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit address its own issue.
Please revise each commit separately and prove that my understanding of code correct.
There is at least one memory leak fix be2464c