Fing clang-tidy issues in hist classes#7596
Merged
linev merged 6 commits intoroot-project:masterfrom Mar 19, 2021
Merged
Conversation
TF3 was never casted if tried to use old function
Second if operation may be dangerous even it should never be true
One can use reference and const specifier to ensure that parameters list not changed
While it handled in static variable, initialize it and verify if it there when access it.
|
Starting build on |
lmoneta
approved these changes
Mar 19, 2021
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Looks good to me, thank you Sergei for these various fixes.
The one in HFitImpl, is maybe a typo but it is a serious bug, probably causing crash. Not noticed so far probably because it is rare to fit a TH3 object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7532