[DF] Add convenience function to describe dataset by stwunsch · Pull Request #7562 · root-project/root

stwunsch · 2021-03-17T11:46:18Z

See the linked issue (#7561) for the discussion of the programming model

phsft-bot · 2021-03-17T11:46:25Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

tree/dataframe/inc/ROOT/RDF/RInterface.hxx

eguiraud

Nice!! I think we should discuss the points you raise in #7561 before merging, but this is basically it.

tree/dataframe/inc/ROOT/RDF/RInterface.hxx

phsft-bot · 2021-03-17T12:07:38Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-17T12:08:33Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-17T12:08:39Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-17T18:55:53Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.dataframe.roottest_root_dataframe_branchoverwrite

phsft-bot · 2021-03-18T08:22:08Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-18T09:30:15Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-2.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.dataframe.roottest_root_dataframe_missingBranches

phsft-bot · 2021-03-18T11:21:34Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-03-18T12:56:58Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

phsft-bot · 2021-03-29T12:39:12Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-29T12:40:30Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:40:29.629Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:41:07Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:41:06.021Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:41:07Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:41:06.327Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:41:08Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:41:07.860Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:41:21Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:41:20.136Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:50:42Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:50:41.686Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:51:04Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:51:03.265Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T12:51:10Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-29T12:51:09.546Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

phsft-bot · 2021-03-29T15:32:16Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

stwunsch · 2021-04-13T10:58:09Z

@phsft-bot build

phsft-bot · 2021-04-13T10:58:14Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-13T17:15:46Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.cmdLineUtils.roottest_python_cmdLineUtils_ROOT_8197

phsft-bot · 2021-04-14T08:22:53Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-14T08:42:08Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-04-14T08:48:46Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

ghost · 2021-04-14T08:56:44Z

Congratulations 🎉. DeepCode analyzed your code in 0.019 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Fixes root-project#7561 Co-authored-by: Enrico Guiraud <[email protected]>

phsft-bot · 2021-04-14T10:01:35Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

stwunsch · 2021-04-14T10:02:17Z

@eguiraud rebased and integrated the requested changes

phsft-bot · 2021-04-14T14:11:19Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-14T16:13:10Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

eguiraud · 2021-04-15T07:20:37Z

Hey, this looks great, please add a mention of Describe to the cheat-sheet in RDataFrame.cxx and it's good to go

phsft-bot · 2021-04-15T08:08:17Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

stwunsch · 2021-04-15T08:08:27Z

Hey, this looks great, please add a mention of Describe to the cheat-sheet in RDataFrame.cxx and it's good to go

@eguiraud Done!

eguiraud · 2021-04-15T08:12:33Z

Sorry last thing, I promise: can you add a line in the 6.26 release notes about this please? So we don't depend on me remembering 😄

phsft-bot · 2021-04-15T08:21:34Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

stwunsch · 2021-04-15T08:22:15Z

Sorry last thing, I promise: can you add a line in the 6.26 release notes about this please? So we don't depend on me remembering 😄

@eguiraud Also done! :D You may want to rephrase the release notes at some point, but I leave this for the future you ;)

eguiraud

Thanks a lot Stefan, super nice work

phsft-bot · 2021-04-15T09:27:05Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

phsft-bot · 2021-04-15T11:10:45Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

stwunsch requested a review from eguiraud as a code owner March 17, 2021 11:46

stwunsch self-assigned this Mar 17, 2021

eguiraud reviewed Mar 17, 2021

View reviewed changes

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

eguiraud reviewed Mar 17, 2021

View reviewed changes

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

eguiraud reviewed Mar 17, 2021

View reviewed changes

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

eguiraud reviewed Mar 17, 2021

View reviewed changes

tree/dataframe/inc/ROOT/RDF/RInterface.hxx Outdated Show resolved Hide resolved

stwunsch linked an issue Mar 17, 2021 that may be closed by this pull request

[DF] Add convenience function to describe the dataframe #7561

Closed

stwunsch requested a review from couet as a code owner March 29, 2021 12:39

stwunsch removed the request for review from couet March 29, 2021 12:47

stwunsch force-pushed the rdf-schema branch from 4bb528e to e8aa541 Compare March 29, 2021 15:32

stwunsch force-pushed the rdf-schema branch from 97b1fa3 to 31e857c Compare April 14, 2021 08:41

stwunsch force-pushed the rdf-schema branch from 31e857c to b50d570 Compare April 14, 2021 08:48

stwunsch requested a review from eguiraud April 14, 2021 08:51

stwunsch and others added 2 commits April 14, 2021 12:01

[DF] Add convenience function Describe

56ba5eb

Fixes root-project#7561 Co-authored-by: Enrico Guiraud <[email protected]>

[DF] Add tutorial for Describe

d3f902a

stwunsch force-pushed the rdf-schema branch from b50d570 to d3f902a Compare April 14, 2021 10:01

[DF][NFC][Doc] Mention Describe in the cheat sheet

7e564c1

[DF][NFC][Doc] Mention Describe in the release notes

a1757ab

stwunsch requested a review from Axel-Naumann as a code owner April 15, 2021 08:21

eguiraud approved these changes Apr 15, 2021

View reviewed changes

stwunsch merged commit f08f640 into root-project:master Apr 15, 2021

Conversation

stwunsch commented Mar 17, 2021

Uh oh!

phsft-bot commented Mar 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eguiraud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

phsft-bot commented Mar 17, 2021

Uh oh!

phsft-bot commented Mar 17, 2021

Uh oh!

phsft-bot commented Mar 17, 2021

Uh oh!

phsft-bot commented Mar 17, 2021

Failing tests:

Uh oh!

phsft-bot commented Mar 18, 2021

Uh oh!

phsft-bot commented Mar 18, 2021

Failing tests:

Uh oh!

phsft-bot commented Mar 18, 2021

Failing tests:

Uh oh!

phsft-bot commented Mar 18, 2021

Uh oh!

phsft-bot commented Mar 29, 2021

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Errors:

Uh oh!

phsft-bot commented Mar 29, 2021

Uh oh!

stwunsch commented Apr 13, 2021

Uh oh!

phsft-bot commented Apr 13, 2021

Uh oh!

phsft-bot commented Apr 13, 2021

Failing tests:

Uh oh!

phsft-bot commented Apr 14, 2021

Uh oh!

phsft-bot commented Apr 14, 2021

Uh oh!

phsft-bot commented Apr 14, 2021

Uh oh!

ghost commented Apr 14, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

phsft-bot commented Apr 14, 2021

Uh oh!

stwunsch commented Apr 14, 2021

Uh oh!

ghost commented Apr 14, 2021 •

edited by ghost

Loading

eguiraud commented Apr 15, 2021 •

edited

Loading