Skip to content

Fix clang-tidy issues in SQL classes#7559

Merged
linev merged 5 commits intoroot-project:masterfrom
linev:tidy_sql
Mar 17, 2021
Merged

Fix clang-tidy issues in SQL classes#7559
linev merged 5 commits intoroot-project:masterfrom
linev:tidy_sql

Conversation

@linev
Copy link
Copy Markdown
Member

@linev linev commented Mar 17, 2021

Partially resolves #7525

@linev linev requested a review from pcanal March 17, 2021 10:09
@linev linev self-assigned this Mar 17, 2021
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 17, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

pcanal
pcanal reviewed Mar 17, 2021
View reviewed changes
pcanal
pcanal reviewed Mar 17, 2021
View reviewed changes
sql/mysql/src/TMySQLStatement.cxx
}

if (allocsize > fgAllocSizeLimit) allocsize = fgAllocSizeLimit;
if ((fgAllocSizeLimit > 256) && (allocsize > fgAllocSizeLimit))
Copy link
Copy Markdown
Member

@pcanal pcanal Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add a comment (or use a constant) explaining the semantic of the 256 here?

Copy link
Copy Markdown
Member Author

@linev linev Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values over 256 bytes used for custom data (like blob or large string).
If user changes fgAllocSizeLimit value to wrongly, this will affect only custom user data but not normal data types

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 17, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 17, 2021

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@linev linev merged commit f1785e9 into root-project:master Mar 17, 2021
@linev linev deleted the tidy_sql branch March 17, 2021 17:26
@linev linev mentioned this pull request Mar 17, 2021
Closed
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Mar 17, 2021

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-03-17T19:05:42.572Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1024 (message):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcanal pcanal pcanal approved these changes

Assignees

@linev linev

Labels

affects:master improvement in:Other

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sql html] Clang-tidy Clazy Warnings

3 participants

@linev @phsft-bot @pcanal