[builtins] Update builtin xrootd to 5.3.0 and move it to proper ROOT builtins#7335
[builtins] Update builtin xrootd to 5.3.0 and move it to proper ROOT builtins#7335linev merged 15 commits intoroot-project:masterfrom
Conversation
|
Starting build on |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Errors:
|
|
Build failed on ROOT-fedora31/noimt. Errors:
|
|
Build failed on mac1014/python3. Errors:
|
|
Build failed on ROOT-performance-centos8-multicore/default. Errors:
|
|
Build failed on ROOT-fedora30/cxx14. Errors:
|
|
Build failed on mac11.0/cxx17. Errors:
|
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on windows10/cxx14. Failing tests: |
|
I am facing problem to build xrootd on my platform - latest OpenSUSE Tumblweed. |
@linev can you post please what do you see as an error? |
It is exactly same error as with 4.12.3, which is mentioned in #7292 |
builtins/xrootd/CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| set(XROOTD_LIBRARIES ${XROOTD_ROOTDIR}/${XROOTD_LIBDIR}/libXrdUtils${CMAKE_SHARED_LIBRARY_SUFFIX} | ||
| ${XROOTD_ROOTDIR}/${XROOTD_LIBDIR}/libXrdClient${CMAKE_SHARED_LIBRARY_SUFFIX} |
There was a problem hiding this comment.
@oshadura
libXrdClient no longer provided in the xrootd 5.x,
If I rermove it here, I can compile ROOT on my system.
Version 5.1 is working for me.
But we have to check that net/netx disabled for xrootd 5.x while net/netx based on client library
There was a problem hiding this comment.
Thanks a lot for feedback! I will add your suggestion.
But we have to check that net/netx disabled for xrootd 5.x while net/netx based on client library
it is already done some time ago.
There was a problem hiding this comment.
it is already done some time ago.
Unfortunately not - if I specify -Dnetx=ON ROOT will try to build it without checking of XROOTD version.
If you want, I can add these fixes to your PR
There was a problem hiding this comment.
hmmm, I thought https://github.com/root-project/root/blob/master/cmake/modules/SearchInstalledSoftware.cmake#L980-L989 will work, let me try to build with -Dnetx=ON.
There was a problem hiding this comment.
I got problem when I call cmake second time adding -Dnetx=ON.
But I have anyway problems with incremental builds now, but this is another issue
There was a problem hiding this comment.
And now you move setting of xrootd version number in other cmake file - is it a problem?
I propose, that these checks done directly in net/netx and net/netxng - at the moment when they build
There was a problem hiding this comment.
Thanks, let me try to experiment with your suggestion.
|
Starting build on |
|
@Axel-Naumann I would like to add this PR to ROOT 6.24. Would it be still possible? |
|
Build failed on ROOT-performance-centos8-multicore/default. Failing tests: |
|
Build failed on ROOT-fedora30/cxx14. Failing tests: |
|
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests: |
|
Build failed on mac11.0/cxx17. Warnings:
Failing tests:
And 4 more |
|
Build failed on ROOT-fedora31/noimt. Failing tests: |
|
Build failed on mac1014/python3. Warnings:
Failing tests: |
|
Build failed on windows10/cxx14. Failing tests: |
|
That depends on when it's in a mergable state. Especially those https://lcgapp-services.cern.ch/root-jenkins/job/root-pullrequests-build/108798/testReport/projectroot.tree.treeplayer/test/gtest_tree_treeplayer_test_treeprocessormt_remotefiles/ and friends seem relevant (IIRC @vepadulano had fixed this in the past?); @eguiraud confirmed that the rdf override / overwrite tests are already fixed. |
These look similar to something that I addressed in the past, that currently is taken care of with https://github.com/root-project/root/blob/master/cmake/modules/XROOTDApplePostInstall.cmake . I tried to look for the messages from that script in the logs of the build (e.g. "Adjusting LC_RPATH variable of XRootD libraries in ${install_libdir}" ) but there was none so maybe that's weird. That being said, in this particular case the error is that |
|
Probably 4.12.8 will be better choice for 6.24 release? |
|
I would prefer xrootd 5 with a lot of new features then xrootd 4. |
|
Starting build on |
|
Build failed on mac11.0/cxx17. Warnings:
Failing tests: |
|
@bellenot @Axel-Naumann it think it is ready to be reviewed! Big thanks to @simonmichal! |
|
Build failed on mac1014/python3. Warnings:
|
|
@phsft-bot build with flags -Dbuildin_xrootd=Off |
|
Starting build on |
|
Build failed on mac11.0/cxx17. Warnings:
Failing tests: |
|
Build failed on mac1014/python3. Warnings:
|
|
The failures are unrelated. |
Axel-Naumann
left a comment
Axel-Naumann
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot, @oshadura and @simonmichal! We still need @linev 's green light, though - so just commenting to not bypass his review.
|
Now ROOT compiles and tests are running. |
|
@phsft-bot build with flags -Dbuiltin_xrootd=Off |
|
Starting build on |
|
(@linev : that's what I was trying to find out with disabling the builtin xrootd but I had a spelling mistake argh.) |
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
|
|
Build failed on mac1014/python3. Errors:
|
|
Looks like compilation was ok - on platforms with installed xrood. |
|
Build failed on mac11.0/cxx17. Failing tests: |
|
Right, ubuntu 16 built with xrootd 4.8.5. @oshadura assigning to you so you have the pleasure to merge :-) |
|
FYI there's still the warning: |
@Axel-Naumann : I'll fix this in next xrootd release, right now there's not much I can do. |
|
Understood but we can (and should) use |
ghost
mentioned this pull request
10 participants
No description provided.