[JupyROOT][6974] Fixes for IPython#6980
Merged
etejedor merged 2 commits intoroot-project:masterfrom Jan 4, 2021
Merged
Conversation
To sync it with what was already introduced in ROOT/__init__.py
When using ipython, the method should be already in the global scope, but as discussed in root-project#6974 it seems this is not always true. An explicit import is therefore safer.
|
Starting build on |
|
Build failed on mac11.0/cxx17. Failing tests: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6974 and also updates the way in which we check if we are in IPython in
JupyROOT/__init__.py, to sync it withROOT/__init__.py.