Skip to content

Revert "Work around vtable index issue due to base class definition b…#682

Merged
vgvassilev merged 1 commit intoroot-project:masterfrom
Axel-Naumann:revertMultiVtablePCM
Aug 15, 2017
Merged

Revert "Work around vtable index issue due to base class definition b…#682
vgvassilev merged 1 commit intoroot-project:masterfrom
Axel-Naumann:revertMultiVtablePCM

Conversation

@Axel-Naumann
Copy link
Copy Markdown
Member

…eing replaced by later PCM."

This reverts commit fc1cb80.
And brings that file back to the original clang version.

…eing replaced by later PCM."

This reverts commit fc1cb80.
And brings that file back to the original clang version.
@phsft-bot
Copy link
Copy Markdown

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@Axel-Naumann
Copy link
Copy Markdown
Member Author

@phsft-bot build!

@phsft-bot
Copy link
Copy Markdown

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@phsft-bot
Copy link
Copy Markdown

@vgvassilev
Copy link
Copy Markdown
Member

@phsft-bot build!

@Axel-Naumann shall we merge that in?

@phsft-bot
Copy link
Copy Markdown

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link
Copy Markdown

@Axel-Naumann
Copy link
Copy Markdown
Member Author

@vgvassilev I'd prefer to first get a status update from say CMS and LHCb: they need to have a green build now, such that we can confirm that this reversed patch doesn't break them. I think this one was (also) visible in LHCb. Could you contact Marco and DavidA to assert that they get a green build with the master?

@vgvassilev
Copy link
Copy Markdown
Member

@davidlt, could we validate if with this PR CMSSW is still fine? @Axel-Naumann I do not have Marco's git handle.

@vgvassilev
Copy link
Copy Markdown
Member

@phsft-bot build!

@phsft-bot
Copy link
Copy Markdown

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants