Skip to content

[cmake] Force the ROOT defaults for CMAKE_CXX_FLAGS_${BUILD_TYPE}#6573

Merged
oshadura merged 1 commit intoroot-project:masterfrom
stwunsch:test-asserts
Oct 7, 2020
Merged

[cmake] Force the ROOT defaults for CMAKE_CXX_FLAGS_${BUILD_TYPE}#6573
oshadura merged 1 commit intoroot-project:masterfrom
stwunsch:test-asserts

Conversation

@stwunsch
Copy link
Copy Markdown
Contributor

@stwunsch stwunsch commented Oct 7, 2020 •
edited
Loading

Forcing the ROOT defaults so they are picked up by the build system. This should fix #6575 and #6574.

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Build failed on ROOT-performance-centos7-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

  • [2020-10-07T09:35:18.996Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:1593 (message):
  • [2020-10-07T09:35:18.996Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1051 (message):

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2020-10-07T09:41:49.073Z] c1 : fatal error C1083: Cannot open source file: 'FORCE': No such file or directory [C:\build\workspace\root-pullrequests-build\build\builtins\zstd\zstd.vcxproj]

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2020-10-07T10:37:38.343Z] axis.obj : fatal error LNK1179: invalid or corrupt file: duplicate COMDAT '??$?8DU?$char_traits@D@std@@@__ROOT@experimental@std@@YA_NV?$basic_string_view@DU?$char_traits@D@std@@@012@0@Z' [C:\build\workspace\root-pullrequests-build\build\hist\histv7\test\histhistv7testUnit.vcxproj]

@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@Axel-Naumann Axel-Naumann requested a review from oshadura October 7, 2020 10:47
@stwunsch stwunsch linked an issue Oct 7, 2020 that may be closed by this pull request
ROOT defaults for CMAKE_C[XX]_FLAGS_${BUILD_TYPE} are not picked up #6574
Closed
@stwunsch stwunsch self-assigned this Oct 7, 2020
@phsft-bot
Copy link
Copy Markdown

phsft-bot commented Oct 7, 2020

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@stwunsch stwunsch marked this pull request as ready for review October 7, 2020 13:22
@stwunsch
Copy link
Copy Markdown
Contributor Author

stwunsch commented Oct 7, 2020

@oshadura If we want to put this in as a short term fix, feel free to approve and also merge.

oshadura
oshadura approved these changes Oct 7, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@oshadura oshadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it (in the case to be reverted)

@oshadura oshadura merged commit 68f1868 into root-project:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oshadura oshadura oshadura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@stwunsch stwunsch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The new -Dasserts=ON flag breaks standalone roottest ROOT defaults for CMAKE_C[XX]_FLAGS_${BUILD_TYPE} are not picked up

3 participants

@stwunsch @phsft-bot @oshadura