[CMake] Fix SearchInstalledSoftware for old CMake versions.#5396
Merged
oshadura merged 1 commit intoroot-project:masterfrom Apr 20, 2020
Merged
[CMake] Fix SearchInstalledSoftware for old CMake versions.#5396oshadura merged 1 commit intoroot-project:masterfrom
oshadura merged 1 commit intoroot-project:masterfrom
Conversation
In cmake < 3.11, one cannot use `target_include_directories` for imported targets. Therefore, a workaround explicitly setting the properties was necessary. The PR CI apparently didn't catch this.
|
Starting build on |
Member
Author
|
@phsft-bot build also on ROOT-ubuntu18.04/default |
|
Starting build on |
oshadura
approved these changes
Apr 20, 2020
1 task
mxxo
added a commit
to mxxo/root
that referenced
this pull request
Mar 24, 2021
Using target_compile_options to set INTERFACE items on IMPORTED targets is only supported in cmake 3.11 and up (see similar PR root-project#5396).
oshadura
pushed a commit
that referenced
this pull request
Mar 24, 2021
Using target_compile_options to set INTERFACE items on IMPORTED targets is only supported in cmake 3.11 and up (see similar PR #5396).
nicknagi
pushed a commit
to nicknagi/root
that referenced
this pull request
Mar 30, 2021
Using target_compile_options to set INTERFACE items on IMPORTED targets is only supported in cmake 3.11 and up (see similar PR root-project#5396).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cmake < 3.11, one cannot use
target_include_directoriesforimported targets. Therefore, a workaround explicitly setting the
properties was necessary.
The PR CI apparently didn't catch this, since for now it's only failing on ubuntu 18.04.