[Exp PyROOT] Port to experimental the new teardown introduced in old PyROOT by etejedor · Pull Request #4753 · root-project/root

etejedor · 2020-01-10T11:26:29Z

Port to PyROOT experimental the new teardown that was introduced in old PyROOT by:

phsft-bot · 2020-01-10T11:26:42Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

They were previously introduced in old PyROOT by 7e47c42.

In the previous implementation, a new C++ object was created for the item being set and later registered together with the Python proxy of the original item, but the original C++ object was never destructed since the proxy was made non-owner. This fix assigns the new C++ object to the proxy and registers the new pair in the memory regulator, but it also unregisters the old pair and deletes the old C++ object.

phsft-bot · 2020-01-10T12:29:54Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

etejedor · 2020-01-10T14:26:10Z

@phsft-bot build with-flags -Dpyroot_experimental=ON

phsft-bot · 2020-01-10T14:26:20Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14
How to customize builds

etejedor · 2020-01-10T15:39:07Z

@phsft-bot build with flags -Dpyroot_experimental=ON

phsft-bot · 2020-01-10T15:39:16Z

Starting build on ROOT-performance-centos7-multicore/default, ROOT-fedora27/noimt, ROOT-fedora29/python3, ROOT-fedora30/cxx14, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu18.04-i386/cxx14, mac1014/cxx17, windows10/cxx14 with flags -Dpyroot_experimental=ON
How to customize builds

phsft-bot · 2020-01-10T15:45:06Z

Build failed on mac1014/cxx17.
See console output.

Errors:

FAILED: bindings/pyroot_experimental/cppyy/CPyCppyy/CMakeFiles/cppyy.dir/src/CallContext.cxx.o
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:534:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:553:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:575:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:593:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/stringobject.h:173:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/stringobject.h:174:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/stringobject.h:175:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
FAILED: bindings/pyroot_experimental/cppyy/CPyCppyy/CMakeFiles/cppyy.dir/src/CPPClassMethod.cxx.o
/System/Library/Frameworks/Python.framework/Versions/2.7/include/python2.7/unicodeobject.h:534:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]

And 62 more

phsft-bot · 2020-01-10T15:55:55Z

Build failed on ROOT-fedora30/cxx14.
See console output.

Warnings:

/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/pythonizations/src/PyROOTModule.cxx:87:57: warning: cast between incompatible function types from ‘PyObject* ()()’ {aka ‘_object ()()’} to ‘PyCFunction’ {aka ‘_object ()(_object, _object*)’} [-Wcast-function-type]

phsft-bot · 2020-01-10T15:59:42Z

Build failed on ROOT-fedora29/python3.
See console output.

Warnings:

/mnt/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/pythonizations/src/PyROOTModule.cxx:87:57: warning: cast between incompatible function types from ‘PyObject* ()()’ {aka ‘_object ()()’} to ‘PyCFunction’ {aka ‘_object ()(_object, _object*)’} [-Wcast-function-type]

phsft-bot · 2020-01-10T16:04:42Z

Build failed on ROOT-ubuntu18.04-i386/cxx14.
See console output.

Errors:

/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/pythonizations/src/TTreePyz.cxx:93:61: error: invalid conversion from ‘long int*’ to ‘dims_t {aka int*}’ [-fpermissive]

Warnings:

/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx:547:88: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/Converters.cxx:547:88: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/CPPMethod.cxx:548:80: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/CPPMethod.cxx:548:80: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/CPPMethod.cxx:552:72: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 2 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/cppyy/CPyCppyy/src/CPPMethod.cxx:552:72: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘Py_ssize_t {aka int}’ [-Wformat=]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/pythonizations/src/CppCallablePyz.cxx:290:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/home/sftnight/build/workspace/root-pullrequests-build/root/bindings/pyroot_experimental/pythonizations/src/RVecPyz.cxx:52:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

phsft-bot · 2020-01-10T17:24:27Z

Build failed on windows10/cxx14.
See console output.

Fix warning: root-project#4753 (comment)

Fix warnings: root-project#4753 (comment)

Fix warning: root-project#4753 (comment)

Fix warnings: root-project#4753 (comment)

Fix warning: #4753 (comment)

Fix warnings: #4753 (comment)

Fix warning: #4753 (comment)

Fix warnings: #4753 (comment)

Fix warning: root-project#4753 (comment)

Fix warnings: root-project#4753 (comment)

Fix warning: root-project#4753 (comment)

Fix warnings: root-project#4753 (comment)

The old PyROOT (pre 2019) had a slightly different `atexit` handler than the new one. The hard shutdown mode is different: `ClearProxiedObjects()` is called before the final `gROOT->EndOfProcessCleanups()`. I had the impresstion that this is redundant, and indeed the old PyROOT didn't do it. This commit suggests to only call `ClearProxiedObjects()` in soft shutdown mode, in an attempt to avoid the frequent crashes seen at the end of PyROOT tutorials, especially on Ubuntu 24.10. See also the original PRs where this functionality was introduced: * root-project#4687 * root-project#4753

etejedor self-assigned this Jan 10, 2020

etejedor mentioned this pull request Jan 10, 2020

[Exp PyROOT] Test copy construction from nullptr and __assign__ root-project/roottest#429

Merged

etejedor added 2 commits January 10, 2020 13:28

[ROOT-10469] Port to exp PyROOT the two teardown modes

f90eb4e

They were previously introduced in old PyROOT by 7e47c42.

etejedor force-pushed the pyteardown_exp branch from 35a4283 to f0dd9be Compare January 10, 2020 12:29

etejedor merged commit a8631ec into root-project:master Jan 13, 2020

etejedor added a commit to etejedor/root that referenced this pull request Jan 13, 2020

[Exp PyROOT] CreateConverter expects dims_t

c578c26

Fix warning: root-project#4753 (comment)

etejedor added a commit to etejedor/root that referenced this pull request Jan 13, 2020

[Exp PyROOT] Prevent comparison between signed and unsigned types

906b49c

Fix warnings: root-project#4753 (comment)

etejedor added a commit to etejedor/root that referenced this pull request Jan 13, 2020

[Exp PyROOT] Respect signature of PyCFunction

d7862cd

Fix warning: root-project#4753 (comment)

etejedor added a commit to etejedor/root that referenced this pull request Jan 13, 2020

[Exp PyROOT] Py_ssize_t is represented with %zd

dfbb090

Fix warnings: root-project#4753 (comment)

etejedor mentioned this pull request Jan 13, 2020

[Exp PyROOT] Fix warnings #4766

Merged

etejedor added a commit that referenced this pull request Jan 13, 2020

[Exp PyROOT] CreateConverter expects dims_t

4fbf316

Fix warning: #4753 (comment)

etejedor added a commit that referenced this pull request Jan 13, 2020

[Exp PyROOT] Prevent comparison between signed and unsigned types

84e729c

Fix warnings: #4753 (comment)

etejedor added a commit that referenced this pull request Jan 13, 2020

[Exp PyROOT] Respect signature of PyCFunction

04cd5c0

Fix warning: #4753 (comment)

etejedor added a commit that referenced this pull request Jan 13, 2020

[Exp PyROOT] Py_ssize_t is represented with %zd

d3fbc75

Fix warnings: #4753 (comment)

rahulgrit pushed a commit to cburgard/root that referenced this pull request Mar 10, 2020

[Exp PyROOT] CreateConverter expects dims_t

b5d8ee1

Fix warning: root-project#4753 (comment)

rahulgrit pushed a commit to cburgard/root that referenced this pull request Mar 10, 2020

[Exp PyROOT] Prevent comparison between signed and unsigned types

9091afd

Fix warnings: root-project#4753 (comment)

rahulgrit pushed a commit to cburgard/root that referenced this pull request Mar 10, 2020

[Exp PyROOT] Respect signature of PyCFunction

3caa027

Fix warning: root-project#4753 (comment)

rahulgrit pushed a commit to cburgard/root that referenced this pull request Mar 10, 2020

[Exp PyROOT] Py_ssize_t is represented with %zd

960a503

Fix warnings: root-project#4753 (comment)

guitargeek mentioned this pull request Oct 14, 2024

[Do not merge][PyROOT] Don't call ClearProxiedObjects() in hard shutdown mode #16671

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Exp PyROOT] Port to experimental the new teardown introduced in old PyROOT#4753

[Exp PyROOT] Port to experimental the new teardown introduced in old PyROOT#4753
etejedor merged 2 commits intoroot-project:masterfrom
etejedor:pyteardown_exp

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

etejedor commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

phsft-bot commented Jan 10, 2020

Errors:

Uh oh!

phsft-bot commented Jan 10, 2020

Warnings:

Uh oh!

phsft-bot commented Jan 10, 2020

Warnings:

Uh oh!

phsft-bot commented Jan 10, 2020

Errors:

Warnings:

Uh oh!

phsft-bot commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants