Restore s390x support in root-config#406
Conversation
|
Can one of the admins verify this patch? |
|
@phsft-bot build! |
|
@phsft-bot build |
|
Hi Mattias, |
|
You are confusing 31 bit s390 with 64 bit s390x. Fedora builds packages for s390x, and I did get a bug report in bugzilla that the package build failed on this architecture, which I tracked down to the problem reported here. Up to Fedora 23 they also used to build for s390, though this does not happen any more. I also filed a bug report to you upstream about some failing tests in s390x. https://sft.its.cern.ch/jira/browse/ROOT-8703. The number of failing tests on s390x is on the same order as the number of failing tests on 32 bit arm (though the failing tests are not the same), and far fewer than the number of failing tests on ppc64 and ppc64le. So while s390 is mostly obsolete, s390x is not. Also Debian builds their packages for s390x. I would not mind if you removed support for s390 - it would make sense since llvm does not support it - but removing s390x would be unfortunate, and s390x is supported by llvm. But also s390 worked if you only used compilation and did not use the interpreter. |
|
Thanks a lot for explaining, Mattias! And yes, I am aware of your ROOT-8703. Thanks for your endurance and continuous flow of contributions! |
…use this was mentioned in the meta issue list (root-project#406 in cling) as one of the rewrite steps. This also allows for the main code to be run as opposed to running the main code plus the function defintions.
Added new main block because this was mentioned in the meta issue list (root-project#406 in cling) as one of the rewrite steps. This also allows for the main code to be run as opposed to running the main code plus the function defintions.
Added new main block because this was mentioned in the meta issue list (#406 in cling) as one of the rewrite steps. This also allows for the main code to be run as opposed to running the main code plus the function defintions.
Added new main block because this was mentioned in the meta issue list (root-project#406 in cling) as one of the rewrite steps. This also allows for the main code to be run as opposed to running the main code plus the function defintions.
5 participants
The s390x arch was lost from root-config. This restores the functionality.