[RF][HF] Check for consistent datasets across channels before combining#21101
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Feb 3, 2026
Merged
[RF][HF] Check for consistent datasets across channels before combining#21101guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
This makes problems like the one reported in root-project#21066 easier to debug by the user, because there will be a meaningful error message like this instead of a crash: ```txt [#2] FATAL:HistFactory -- ERROR: Inconsistent datasets across channel workspaces. Workspace for channel "SR_3L_0RC_binary_binary_3L_0RC" does not match the datasets in channel "SR_2L_mva_2L_multiclass_ttll". Missing datasets: - obsData All channel workspaces must contain exactly the same datasets. terminate called after throwing an instance of 'RooStats::HistFactory::hf_exc' what(): HistFactory - Exception ```
1 task
Test Results 22 files 22 suites 3d 16h 56m 55s ⏱️ Results for commit 3649c5f. ♻️ This comment has been updated with latest results. |
lmoneta
approved these changes
Feb 3, 2026
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you Jonas for adding this conistency check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes problems like the one reported in #21066 easier to debug by the user, because there will be a meaningful error message like this instead of a crash:
[#2] FATAL:HistFactory -- ERROR: Inconsistent datasets across channel workspaces. Workspace for channel "SR_3L_0RC_binary_binary_3L_0RC" does not match the datasets in channel "SR_2L_mva_2L_multiclass_ttll". Missing datasets: - obsData All channel workspaces must contain exactly the same datasets. terminate called after throwing an instance of 'RooStats::HistFactory::hf_exc' what(): HistFactory - ExceptionCloses #21066